[browser] remove legacy js interop (dotnet#96841)

.gitattributes

@@ -78,4 +78,3 @@ src/tests/JIT/Performance/CodeQuality/BenchmarksGame/reverse-complement/revcomp-
 src/tests/JIT/Performance/CodeQuality/BenchmarksGame/k-nucleotide/knucleotide-input.txt text eol=lf
 src/tests/JIT/Performance/CodeQuality/BenchmarksGame/k-nucleotide/knucleotide-input-big.txt text eol=lf
 src/mono/wasm/runtime/dotnet.d.ts text eol=lf
-src/mono/wasm/runtime/dotnet-legacy.d.ts text eol=lf

eng/liveBuilds.targets

@@ -204,7 +204,6 @@
  $(LibrariesNativeArtifactsPath)dotnet.runtime.js;
  $(LibrariesNativeArtifactsPath)dotnet.runtime.js.map;
  $(LibrariesNativeArtifactsPath)dotnet.d.ts;
- $(LibrariesNativeArtifactsPath)dotnet-legacy.d.ts;
  $(LibrariesNativeArtifactsPath)package.json;
  $(LibrariesNativeArtifactsPath)dotnet.native.wasm;
  $(LibrariesNativeArtifactsPath)dotnet.native.js.symbols;

eng/testing/tests.browser.targets

@@ -33,7 +33,6 @@
  >true</InstallV8ForTests>
 
  <_BundleAOTTestWasmAppForHelixDependsOn>$(_BundleAOTTestWasmAppForHelixDependsOn);PrepareForWasmBuildApp;_PrepareForAOTOnHelix</_BundleAOTTestWasmAppForHelixDependsOn>
- <WasmEnableLegacyJsInterop Condition="'$(WasmEnableLegacyJsInterop)' == ''">true</WasmEnableLegacyJsInterop>
  <UseSystemResourceKeys Condition="'$(UseSystemResourceKeys)' == ''">false</UseSystemResourceKeys>
  <EventSourceSupport Condition="'$(EventSourceSupport)' == ''">true</EventSourceSupport>
  <NullabilityInfoContextSupport Condition="'$(NullabilityInfoContextSupport)' == ''">true</NullabilityInfoContextSupport>
@@ -47,21 +46,6 @@
  <WasmIncludeFullIcuData>true</WasmIncludeFullIcuData>
  </PropertyGroup>
 
- <PropertyGroup Condition="'$(BuildAOTTestsOn)' == 'local'">
- <!--
- When building for BuildAOTTestsOnHelix=true, the BrowserWasmApp.targets are *not* imported, because
- they get instead used by the AOT proxy project on helix.
-
- On the build machine only the regular part of the build is run, which includes trimming. But if
- BrowserWasmApp.targets modify any trimming arguments, then those will not get picked up by this build.
- For example - linker substitution files used with simd builds.
-
- So, set those parameters explicitly here.
- -->
- <_ExtraTrimmerArgs Condition="'$(WasmEnableLegacyJsInterop)' == 'false'">$(_ExtraTrimmerArgs) --substitutions "$(BrowserProjectRoot)build\ILLink.Substitutions.LegacyJsInterop.xml"</_ExtraTrimmerArgs>
- </PropertyGroup>
-
-
  <!-- On CI this is installed as part of pretest, but it should still be installed
  for WBT, and debugger tests -->
  <Import Project="$(MSBuildThisFileDirectory)wasm-provisioning.targets"

src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props

@@ -231,7 +231,6 @@
  <PlatformManifestFileEntry Include="dotnet.native.worker.js" IsNative="true" />
  <PlatformManifestFileEntry Include="dotnet.native.js.symbols" IsNative="true" />
  <PlatformManifestFileEntry Include="dotnet.d.ts" IsNative="true" />
- <PlatformManifestFileEntry Include="dotnet-legacy.d.ts" IsNative="true" />
  <PlatformManifestFileEntry Include="dotnet.native.wasm" IsNative="true" />
  <PlatformManifestFileEntry Include="icudt.dat" IsNative="true" />
  <PlatformManifestFileEntry Include="icudt_no_CJK.dat" IsNative="true" />

src/libraries/System.Runtime.InteropServices.JavaScript/System.Runtime.InteropServices.JavaScript.sln

@@ -11,8 +11,6 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "System.Runtime.InteropServi
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "JSImportGenerator.Unit.Tests", "tests\JSImportGenerator.UnitTest\JSImportGenerator.Unit.Tests.csproj", "{BFED925C-18F2-4C98-833E-66F205234598}"
 EndProject
-Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "System.Runtime.InteropServices.JavaScript.Legacy.Tests", "tests\System.Runtime.InteropServices.JavaScript.Legacy.UnitTests\System.Runtime.InteropServices.JavaScript.Legacy.Tests.csproj", "{ABA5A92B-CAD8-47E8-A7CE-D28A67FB69C0}"
-EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "System.Runtime.InteropServices.JavaScript.Tests", "tests\System.Runtime.InteropServices.JavaScript.UnitTests\System.Runtime.InteropServices.JavaScript.Tests.csproj", "{765B4AA5-723A-44FF-BC4E-EB0F03103F6D}"
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ComInterfaceGenerator", "..\System.Runtime.InteropServices\gen\ComInterfaceGenerator\ComInterfaceGenerator.csproj", "{FB12C247-AFEF-4772-BB0C-983969B6CF32}"

src/libraries/System.Runtime.InteropServices.JavaScript/src/CompatibilitySuppressions.xml

@@ -1,42 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
- <Suppression>
- <DiagnosticId>CP0001</DiagnosticId>
- <Target>T:System.Runtime.InteropServices.JavaScript.Array</Target>
- <Left>ref/net9.0/System.Runtime.InteropServices.JavaScript.dll</Left>
- <Right>runtimes/browser/lib/net9.0/System.Runtime.InteropServices.JavaScript.dll</Right>
- </Suppression>
- <Suppression>
- <DiagnosticId>CP0001</DiagnosticId>
- <Target>T:System.Runtime.InteropServices.JavaScript.ArrayBuffer</Target>
- <Left>ref/net9.0/System.Runtime.InteropServices.JavaScript.dll</Left>
- <Right>runtimes/browser/lib/net9.0/System.Runtime.InteropServices.JavaScript.dll</Right>
- </Suppression>
- <Suppression>
- <DiagnosticId>CP0001</DiagnosticId>
- <Target>T:System.Runtime.InteropServices.JavaScript.DataView</Target>
- <Left>ref/net9.0/System.Runtime.InteropServices.JavaScript.dll</Left>
- <Right>runtimes/browser/lib/net9.0/System.Runtime.InteropServices.JavaScript.dll</Right>
- </Suppression>
- <Suppression>
- <DiagnosticId>CP0001</DiagnosticId>
- <Target>T:System.Runtime.InteropServices.JavaScript.Function</Target>
- <Left>ref/net9.0/System.Runtime.InteropServices.JavaScript.dll</Left>
- <Right>runtimes/browser/lib/net9.0/System.Runtime.InteropServices.JavaScript.dll</Right>
- </Suppression>
- <Suppression>
- <DiagnosticId>CP0001</DiagnosticId>
- <Target>T:System.Runtime.InteropServices.JavaScript.Runtime</Target>
- <Left>ref/net9.0/System.Runtime.InteropServices.JavaScript.dll</Left>
- <Right>runtimes/browser/lib/net9.0/System.Runtime.InteropServices.JavaScript.dll</Right>
- </Suppression>
- <Suppression>
- <DiagnosticId>CP0001</DiagnosticId>
- <Target>T:System.Runtime.InteropServices.JavaScript.Uint8Array</Target>
- <Left>ref/net9.0/System.Runtime.InteropServices.JavaScript.dll</Left>
- <Right>runtimes/browser/lib/net9.0/System.Runtime.InteropServices.JavaScript.dll</Right>
- </Suppression>
-
  <Suppression>
  <DiagnosticId>CP0001</DiagnosticId>
  <Target>T:System.Runtime.InteropServices.JavaScript.SynchronizationContextExtension</Target>

src/libraries/System.Runtime.InteropServices.JavaScript/src/System.Runtime.InteropServices.JavaScript.csproj

@@ -14,9 +14,7 @@
  <FeatureWasmThreads Condition="'$(TargetPlatformIdentifier)' == 'browser' and '$(MonoWasmBuildVariant)' == 'multithread'">true</FeatureWasmThreads>
  <WasmEnableJsInteropByValue Condition="'$(TargetPlatformIdentifier)' == 'browser' and '$(WasmEnableJsInteropByValue)' == '' and '$(FeatureWasmThreads)' == 'true'">true</WasmEnableJsInteropByValue>
  <WasmEnableJsInteropByValue Condition="'$(TargetPlatformIdentifier)' == 'browser' and '$(WasmEnableJsInteropByValue)' == ''">false</WasmEnableJsInteropByValue>
- <WasmEnableLegacyJsInterop Condition="'$(TargetPlatformIdentifier)' == 'browser' and '$(WasmEnableLegacyJsInterop)' == ''">true</WasmEnableLegacyJsInterop>
  <DefineConstants Condition="'$(FeatureWasmThreads)' == 'true'">$(DefineConstants);FEATURE_WASM_THREADS</DefineConstants>
- <DefineConstants Condition="'$(WasmEnableLegacyJsInterop)' == 'false'">$(DefineConstants);DISABLE_LEGACY_JS_INTEROP</DefineConstants>
  <DefineConstants Condition="'$(WasmEnableJsInteropByValue)' == 'true'">$(DefineConstants);ENABLE_JS_INTEROP_BY_VALUE</DefineConstants>
  <EmitCompilerGeneratedFiles Condition="'$(Configuration)' == 'Debug' and '$(TargetPlatformIdentifier)' == 'browser'">true</EmitCompilerGeneratedFiles>
  </PropertyGroup>
@@ -29,7 +27,6 @@
  <Compile Include="$(CommonPath)Interop\Browser\Interop.Runtime.cs" Link="System\Runtime\InteropServices\JavaScript\Interop\Interop.Runtime.cs" />
  <Compile Include="System\Runtime\InteropServices\JavaScript\Interop\JavaScriptImports.Generated.cs" />
  <Compile Include="System\Runtime\InteropServices\JavaScript\Interop\JavaScriptExports.cs" />
- <Compile Include="System\Runtime\InteropServices\JavaScript\Interop\JavaScriptImports.cs" />
 
  <Compile Include="System\Runtime\InteropServices\JavaScript\JSHost.cs" />
  <Compile Include="System\Runtime\InteropServices\JavaScript\JSMarshalerType.cs" />
@@ -68,18 +65,6 @@
  <Compile Include="System\Runtime\InteropServices\JavaScript\Marshaling\JSMarshalerArgument.Exception.cs" />
  </ItemGroup>
 
- <!-- only include legacy interop when WasmEnableLegacyJsInterop is enabled -->
- <ItemGroup Condition="'$(TargetPlatformIdentifier)' == 'browser' and '$(WasmEnableLegacyJsInterop)' != 'false'">
- <Compile Include="System\Runtime\InteropServices\JavaScript\Interop\LegacyExports.cs" />
- <Compile Include="System\Runtime\InteropServices\JavaScript\Legacy\Runtime.cs" />
- <Compile Include="System\Runtime\InteropServices\JavaScript\Legacy\Array.cs" />
- <Compile Include="System\Runtime\InteropServices\JavaScript\Legacy\ArrayBuffer.cs" />
- <Compile Include="System\Runtime\InteropServices\JavaScript\Legacy\DataView.cs" />
- <Compile Include="System\Runtime\InteropServices\JavaScript\Legacy\Function.cs" />
- <Compile Include="System\Runtime\InteropServices\JavaScript\Legacy\Uint8Array.cs" />
- <Compile Include="System\Runtime\InteropServices\JavaScript\Legacy\LegacyHostImplementation.cs" />
- </ItemGroup>
-
  <!-- only include threads support when FeatureWasmThreads is enabled -->
  <ItemGroup Condition="'$(TargetPlatformIdentifier)' == 'browser' and '$(FeatureWasmThreads)' == 'true'">
  <Compile Include="System\Runtime\InteropServices\JavaScript\JSWebWorker.cs" />