Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: adding address details #226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feature: adding address details #226

wants to merge 1 commit into from

Conversation

tobiasehlert
Copy link
Owner

@tobiasehlert tobiasehlert commented Jun 12, 2023 •
edited
Loading

  • added AddressDetails for all endpoints
  • changing string to NullString for carName
  • fixing NullString

original PR by @vbarrier: #212

@tobiasehlert tobiasehlert added enhancement New feature or request go Pull requests that update Go code labels Jun 12, 2023
@tobiasehlert tobiasehlert self-assigned this Jun 12, 2023
@sonarcloud

This comment was marked as outdated.

Sign in to view
@tobiasehlert tobiasehlert changed the title adding address details (#212) Feature: adding address details Jun 12, 2023
@tobiasehlert tobiasehlert mentioned this pull request Sep 12, 2023
Closed
@tobiasehlert
Copy link
Owner Author

@vbarrier, run some tests and the queries don't seem to be fully working.

I noticed for instance that the house_number is returned in end_address but not in end_address_details.house_number.

We need to fix this before merging.. but I think I'll merge the NullString part separately first, since new users encounter issues with TeslaMateApi when not setting a carname :)

@tobiasehlert
Copy link
Owner Author

I noticed for instance that the house_number is returned in end_address but not in end_address_details.house_number.

Checked against a geofenced address and not another.. therefore the parameters on the address details section can be faulty 🤔

@tobiasehlert
Copy link
Owner Author

Moved CarName fix to #242.

@tobiasehlert @vbarrier
adding address details (#212)
48cd0ae 
- added AddressDetails for all endpoints

Co-Authored-By: Vincent Barrier <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
35.7% 35.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@vbarrier
Copy link
Contributor

Thank you for fixing carName null bug :)

@vbarrier
Copy link
Contributor

I will have a look on the house_number thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tobiasehlert tobiasehlert

Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasehlert @vbarrier