This repository has been archived by the owner on Jan 2, 2023. It is now read-only.
Allow serializers to add metadata #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change Serializers can provide metadata like::
```
class PostSerializer implements SerializerInterface
{
// ...
public function getMeta() {
return ['some' => 'metadata'];
}
}
```
Resolves #64
| @@ -167,12 +195,17 @@ public function comments($post) | |||
| return new Relationship(new Collection($post->comments, new CommentSerializer)); | |||
| } | |||
| } | |||
| class PostSerializer4WithLinks extends PostSerializer4 | |||
| class PostSerializer4WithLinksAndMeta extends PostSerializer4 | |||
There was a problem hiding this comment.
Each class must be in a file by itself
| if (! empty($this->meta)) { | ||
| $meta = $this->meta; | ||
| } | ||
| $serializerMeta = $this->serializer->getMeta(); |
There was a problem hiding this comment.
Can we pass $this->data into getMeta(), like we do with getLinks()?
There was a problem hiding this comment.
Good catch, I'll post a follow-up
With this change Serializers can provide metadata like::
```
class PostSerializer implements SerializerInterface
{
// ...
public function getMeta($post) {
return ['some' => 'metadata for ' . $post->id];
}
}
```
Related #64
tobyzerner
added a commit
that referenced
this pull request
Feb 24, 2016
Allow serializers to add metadata
|
Perfect, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change Serializers can provide metadata like::
Resolves #64