Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mutexes around boxed services #2947

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Remove mutexes around boxed services #2947

merged 1 commit into from
Sep 29, 2024

Conversation

jplatte
Copy link
Member

@jplatte jplatte commented Sep 28, 2024

They're no longer needed with services being required to implement Sync. (#2473)

@jplatte
Remove mutexes around boxed services
6c56039 
They're no longer needed with services being required to implement Sync.
daheige
daheige approved these changes Sep 29, 2024
View reviewed changes
Copy link

@daheige daheige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
There is really no need for mutex locks here, and I agree with this change.

mladedav
mladedav approved these changes Sep 29, 2024
View reviewed changes
Copy link
Collaborator

@mladedav mladedav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jplatte jplatte merged commit fb4b189 into main Sep 29, 2024
18 checks passed
@jplatte jplatte deleted the jplatte/rm-custom-mutex branch September 29, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daheige daheige daheige approved these changes

@mladedav mladedav mladedav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jplatte @daheige @mladedav