-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conversion from BytesMut to Vec<u8> #543
Conversation
I'm not a super big fan of using a I also wonder about your |
You are right, I should probably just implement a |
@Darksonn I have replaced the |
Pinging this PR |
03b9a12
to
99bd350
Compare
I'd love to have this as well, to avoid having to open-code it in multiple places. |
3a346c7
to
45aef09
Compare
CI/miri failed due to strict provenance being enabled and the bytes codebase uses integer-pointer conversions and vice versa. I also run miri locally with strict provenance and it succeeded with warning on integer-pointer cast. This PR itself does not add any integer-pointer conversion, so it should not block this PR from being merged. |
Master has a commit that makes bytes compatible with strict provenance, but your PR doesn't appear to have it. Can you rebase/merge in master? |
@Darksonn I've just rebased this PR today. |
You must have forgotten to pull the changes from our master before rebasing, because your PR's branch does not have any changes newer than April 15. |
@Darksonn But my master branch is up-to-date. |
Oh. I see what's going on. One of our representations of |
Please see #553. |
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Ensure that if new kind/vtable is added to `BytesMut` in the future, `Into<Vec<u8>>` would still work. Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
45aef09
to
d3c8b8d
Compare
@Darksonn I have rebased this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Fixed #427
Signed-off-by: Jiahao XU [email protected]