net: Add take_error
to TcpSocket
and TcpStream
#4739
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When manually creating a
TcpSocket
orTcpStream
e.g. viatokio::net::TcpStream::try_from
one should be able to check for errors after awaiting the connection to be writable (writable()
) before assuming the connection to be successfully established.This is needed e.g. in rust-libp2p, see libp2p/rust-libp2p#2458.
Solution
The first commit reintroduces #4364 which first merged but later on reverted in #4392. See also #4392 (comment).
The second commit adds the same method to
TcpStream
.Tagging @taiki-e as the initial author.