Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nightly to nightly-2024-05-05 #6538

Merged
merged 23 commits into from
May 5, 2024

Conversation

Darksonn
Copy link
Contributor

@Darksonn Darksonn commented May 5, 2024

Silence warnings from rust-lang/cargo#13571.

I tried to add a CI step that runs with the lint enabled as well. But it can't be enabled normally because cargo build needs to just work for new contributors, and build scripts hurt performance too much.

@Darksonn Darksonn added the A-ci Area: The continuous integration setup label May 5, 2024
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Fixes this error:
   error[E0635]: unknown feature `stdsimd`
    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ahash-0.8.4/src/lib.rs:99:42
     |
  99 | #![cfg_attr(feature = "stdsimd", feature(stdsimd))]
     |                                          ^^^^^^^

As of 0.8.7, ahash no longer tries to use stdsimd on nightly
@Darksonn Darksonn changed the title Silence unexpected-cfgs warnings Bump nightly to nightly-2024-05-05 May 5, 2024
@Darksonn Darksonn added R-loom Run loom tests on this PR R-loom-sync Run loom sync tests on this PR labels May 5, 2024
@Darksonn Darksonn added R-loom-time-driver Run loom time driver tests on this PR R-loom-current-thread Run loom current-thread tests on this PR R-loom-multi-thread Run loom multi-thread tests on this PR R-loom-multi-thread-alt Run loom multi-thread alt tests on this PR labels May 5, 2024
tokio-util/Cargo.toml Outdated Show resolved Hide resolved
@Darksonn
Copy link
Contributor Author

Darksonn commented May 5, 2024

Verified that everything including loom passes!

@github-actions github-actions bot removed R-loom-current-thread Run loom current-thread tests on this PR R-loom-multi-thread-alt Run loom multi-thread alt tests on this PR R-loom-time-driver Run loom time driver tests on this PR R-loom-sync Run loom sync tests on this PR R-loom-multi-thread Run loom multi-thread tests on this PR labels May 5, 2024
@Darksonn Darksonn enabled auto-merge (squash) May 5, 2024 15:28
@Darksonn Darksonn merged commit 2a0df5f into tokio-rs:master May 5, 2024
83 checks passed
@Darksonn Darksonn deleted the alice/unexpected-cfgs branch May 5, 2024 18:22
tbu- added a commit to tbu-/rust that referenced this pull request May 7, 2024
This allows to find solutions to the false positives that were found in
the ecosystem before turning it to `warn` by default again.

Most projects hit by this seem to just disable the warning, which
indicates that it isn't working as expected.

CC rust-lang#124800
CC rust-lang#124804
CC rust-lang#124821
CC hyperium/hyper#3660
CC microsoft/windows-rs#3022
CC rust-bitcoin/rust-bitcoin#2748
CC tokio-rs/tokio#6538
@Urgau
Copy link

Urgau commented May 23, 2024

Heads up, with the release of rust-lang/cargo#13913 (in nightly-2024-05-19), there is no longer any need for the kind of workarounds employed in this PR. Cargo has now gain the ability to declare --check-cfg args directly inside the [lints] table with [lints.rust.unexpected_cfgs.check-cfg]1:

Cargo.toml:

[lints.rust]
unexpected_cfgs = { level = "warn", check-cfg = ['cfg(foo)'] }

Note that the diagnostic output of the lint has been updated to suggest the [lints] approach first. You can use it to guide you through the --check-cfg arguments that may need to be added.

Footnotes

  1. take effect on Rust 1.80 (current nightly), is ignored on Rust 1.79 (current beta), and produce an unused warning below

@mox692
Copy link
Member

mox692 commented May 24, 2024

@Urgau
Thank you for sharing.
Can you open a new issue so we don't miss it?

@Urgau
Copy link

Urgau commented May 24, 2024

Can you open a new issue so we don't miss it?

#6583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: The continuous integration setup R-loom Run loom tests on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants