Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value is not Implemented for Option<T> #2745

Closed
AmoleR opened this issue Oct 10, 2023 · 2 comments
Closed

Value is not Implemented for Option<T> #2745

AmoleR opened this issue Oct 10, 2023 · 2 comments

Comments

@AmoleR
Copy link

AmoleR commented Oct 10, 2023

#1585 added impl Value for Option<T> so we weren't writing cumbersome code, but this code is not implemented in the master branch (upcoming release).

I don't think there should be any reason to not include this in the master, and it would help greatly.

If you would like, I could tackle this.

@safinaskar
Copy link

See valuable branch. It makes impl Value for Option not needed. But I disagree with how they solved the problem, my arguments are here: #2777

@davidbarsky
Copy link
Member

We'll be removing the Value trait in 0.2 and replacing it with valuable, so while it is kind of you to offer to implement this, it's not necessary :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants