fmt: Add basic span value filtering #22
Conversation
| Err(()) | ||
| if let Some((ref field, ref val)) = directive.in_field_value { | ||
| let fields = span.fields(); | ||
| let matcher = format!("{}={:?}", field, val); |
There was a problem hiding this comment.
prob could make this a lot better just wanted to get it working for my use case 😅
There was a problem hiding this comment.
Having to allocate here is definitely quite unfortunate. This is a consequence of how span fields are currently represented (as a single string), which is primarily a performance optimization. We may want to reconsider that choice to make this use case a little more efficient.
| fn parse_span_target(from: &str) -> Option<(Option<String>, Option<String>)> { | ||
| fn parse_span_target( | ||
| from: &str, | ||
| ) -> Option<(Option<String>, Option<String>, Option<(String, String)>)> { |
There was a problem hiding this comment.
Yeah, this needs to be a struct now...
| part0 | ||
| // part0 | ||
|
|
||
| if let Some(part0) = part0 { |
There was a problem hiding this comment.
We probably should just bite the bullet at this point and replace the hand-written parser with a regex; this is really getting out of hand.
(i'm sorry for inflicting this code on you)
There was a problem hiding this comment.
no problem! I have written way worse parsers :P
|
@LucioFranco also, I'd really prefer to use a syntax like because the |
Co-Authored-By: LucioFranco <[email protected]>
|
@hawkw I like that syntax better but its just not possible with this current parser, so how I'd rather move forward is to do it this way then change, since it doesn't actually affect code just the env var. |
|
@LucioFranco I'd really rather not introduce a syntax for the env var and then immediately break it...if you like, I can go ahead and rewrite the parser with a regex and then we can rebase this PR on top of that? |
|
im gonna close this and open up a new one when #25 is merged. |
|
@LucioFranco okay, the regex parser is on master now! thanks for your willingness to wait for that change and redo... |
This adds a new syntax for filtering based on values inside a span. The syntax can be used like so:
app[spanA{field:val}]=levelcurrently, it only works with strings due to how values are recorded into the slot.