Skip to content

Commit

Permalink
formatting fix
Browse files Browse the repository at this point in the history
  • Loading branch information
hkfgo committed Jul 14, 2023
1 parent 00feaf6 commit d334776
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
4 changes: 3 additions & 1 deletion src/Promitor.Core.Scraping/AzureMonitorScraper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ protected override async Task<ScrapeResult> ScrapeResourceAsync(string subscript
{
Logger.LogWarning("No metric information found for metric {MetricName} with dimension {MetricDimension}. Details: {Details}", metricsNotFoundException.Name, metricsNotFoundException.Dimension, metricsNotFoundException.Details);

var measuredMetric = string.IsNullOrWhiteSpace(dimensionName) ? MeasuredMetric.CreateWithoutDimension(null) : MeasuredMetric.CreateForDimension(null, dimensionName, "unknown");
var measuredMetric = string.IsNullOrWhiteSpace(dimensionName)
? MeasuredMetric.CreateWithoutDimension(null)
: MeasuredMetric.CreateForDimension(null, dimensionName, "unknown");
measuredMetrics.Add(measuredMetric);
}

Expand Down
6 changes: 4 additions & 2 deletions src/Promitor.Integrations.AzureMonitor/AzureMonitorClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -112,13 +112,15 @@ public async Task<List<MeasuredMetric>> QueryMetricAsync(string metricName, stri
var requestedMetricAggregate = InterpretMetricValue(aggregationType, mostRecentMetricValue);
try
{
var measuredMetric = string.IsNullOrWhiteSpace(metricDimension) ? MeasuredMetric.CreateWithoutDimension(requestedMetricAggregate) : MeasuredMetric.CreateForDimension(requestedMetricAggregate, metricDimension, timeseries);
var measuredMetric = string.IsNullOrWhiteSpace(metricDimension)
? MeasuredMetric.CreateWithoutDimension(requestedMetricAggregate)
: MeasuredMetric.CreateForDimension(requestedMetricAggregate, metricDimension, timeseries);
measuredMetrics.Add(measuredMetric);
}
catch (MissingDimensionException)
{
_logger.LogWarning("{MetricName} has return a time series with empty value for {Dimension} and the measurements will be dropped", metricName, metricDimension);
_logger.LogDebug("The violating time series has content {TimeSeriesJson}}", JsonConvert.SerializeObject(timeseries));
_logger.LogDebug("The violating time series has content {Details}", JsonConvert.SerializeObject(timeseries));
}
}

Expand Down

0 comments on commit d334776

Please sign in to comment.