</ renders as normal Fira Mono on empty html tags #235
Comments
|
Strange... it seems to work correctly on line 9 and 10!? |
|
What editor are you using? I'm seeing this problem on Atom, but only if the syntax is set to HTML. This implies that the problem is not with FiraCode, but with how Atom's HTML syntax highlighter is tokenizing the text. |
|
Looks like you're right @weavejester. This is a problem with the language-html package on Atom. @jdreesen, great catch. I didn't even see this. This also has to do with how language-html handles script tags. For some reason |
Losangelosgenetics
pushed a commit
to Losangelosgenetics/FiraCode
that referenced
this issue
Mar 12, 2020
235: Update rubocop requirement from = 0.69.0 to = 0.70.0 r=olleolleolle a=dependabot[bot] Updates the requirements on [rubocop](https:/rubocop-hq/rubocop) to permit the latest version. <details> <summary>Release notes</summary> *Sourced from [rubocop's releases](https:/rubocop-hq/rubocop/releases).* > ## RuboCop 0.70 > ### New features > > * [#6649](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6649): `Layout/AlignHash` supports list of options. ([@​stoivo][]) > * Add `IgnoreMethodPatterns` config option to `Style/MethodCallWithArgsParentheses`. ([@​tejasbubane][]) > * [#7059](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/7059): Add `EnforcedStyle` to `Layout/EmptyLinesAroundAccessModifier`. ([@​koic][]) > * [#7052](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/7052): Add `AllowComments` option to ` Lint/HandleExceptions`. ([@​tejasbubane][]) > > ### Bug fixes > > * [#7013](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/7013): Respect DisabledByDefault for custom cops. ([@​XrXr][]) > * [#7043](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/7043): Prevent RDoc error when installing RuboCop 0.69.0 on Ubuntu. ([@​koic][]) > * [#7023](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/7023): Autocorrection for `Lint/NumberConversion`. ([@​Bhacaz][]) > > ### Changes > > * [#6359](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6359): Mark `Style/PreferredHashMethods` as unsafe. ([@​tejasbubane][]) > > [@​stoivo]: https:/stoivo > [@​tejasbubane]: https:/tejasbubane > [@​koic]: https:/koic > [@​XrXr]: https:/XrXr > [@​Bhacaz]: https:/Bhacaz </details> <details> <summary>Changelog</summary> *Sourced from [rubocop's changelog](https:/rubocop-hq/rubocop/blob/master/CHANGELOG.md).* > ## 0.70.0 (2019-05-21) > > ### New features > > * [#6649](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6649): `Layout/AlignHash` supports list of options. ([@​stoivo][]) > * Add `IgnoreMethodPatterns` config option to `Style/MethodCallWithArgsParentheses`. ([@​tejasbubane][]) > * [#7059](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/7059): Add `EnforcedStyle` to `Layout/EmptyLinesAroundAccessModifier`. ([@​koic][]) > * [#7052](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/7052): Add `AllowComments` option to ` Lint/HandleExceptions`. ([@​tejasbubane][]) > > ### Bug fixes > > * [#7013](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/7013): Respect DisabledByDefault for custom cops. ([@​XrXr][]) > * [#7043](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/7043): Prevent RDoc error when installing RuboCop 0.69.0 on Ubuntu. ([@​koic][]) > * [#7023](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/7023): Autocorrection for `Lint/NumberConversion`. ([@​Bhacaz][]) > > ### Changes > > * [#6359](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6359): Mark `Style/PreferredHashMethods` as unsafe. ([@​tejasbubane][]) > > ## 0.69.0 (2019-05-13) > > ### New features > > * Add support for subclassing using `Class.new` to `Lint/InheritException`. ([@​houli][]) > * [#6779](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6779): Add new cop `Style/NegatedUnless` that checks for unless with negative condition. ([@​tejasbubane][]) > > ### Bug fixes > > * [#6900](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6900): Fix `Rails/TimeZone` autocorrect `Time.current` to `Time.zone.now`. ([@​vfonic][]) > * [#6900](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6900): Fix `Rails/TimeZone` to prefer `Time.zone.#{method}` over other acceptable corrections. ([@​vfonic][]) > * [#7007](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/7007): Fix `Style/BlockDelimiters` with `braces_for_chaining` style false positive, when chaining using safe navigation. ([@​Darhazer][]) > * [#6880](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6880): Fix `.rubocop` file parsing. ([@​hoshinotsuyoshi][]) > * [#5782](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/5782): Do not autocorrect `Lint/UnifiedInteger` if `TargetRubyVersion < 2.4`. ([@​lavoiesl][]) > * [#6387](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6387): Prevent `Lint/NumberConversion` from reporting error with `Time`/`DateTime`. ([@​tejasbubane][]) > * [#6980](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6980): Fix `Style/StringHashKeys` to allow string as keys for hash arguments to gsub methods. ([@​tejasbubane][]) > * [#6969](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6969): Fix a false positive with block methods in `Style/InverseMethods`. ([@​dduugg][]) > * [#6729](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/6729): Handle array spread for `change_column_default` in `Rails/ReversibleMigration` cop. ([@​tejasbubane][]) > * [#7033](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/7033): Fix an error for `Layout/EmptyLineAfterGuardClause` when guard clause is a ternary operator. ([@​koic][]) > > ### Changes > > * [#6945](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6945): Drop support for Ruby 2.2. ([@​koic][]) > * [#6945](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6945): Set default `EnforcedStyle` to `squiggly` option for `Layout/IndentHeredoc` and `auto_detection` option is removed. ([@​koic][]) > * [#6945](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6945): Set default `EnforcedStyle` to `always` option for `Style/FrozenStringLiteralComment` and `when_needed` option is removed. ([@​koic][]) > * [#7027](https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/7027): Allow `unicode/display_width` dependency version 1.6.0. ([@​tagliala][]) > > ## 0.68.1 (2019-04-30) > > ### Bug fixes > ></tr></table> ... (truncated) </details> <details> <summary>Commits</summary> - [`959f215`](rubocop/rubocop@959f215) Cut 0.70 - [`7a21748`](rubocop/rubocop@7a21748) Merge pull request [#7065](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/7065) from koic/fix_a_ci_error - [`6a4f586`](rubocop/rubocop@6a4f586) Fix a CI error - [`8a7ee84`](rubocop/rubocop@8a7ee84) Add `EnforcedStyle` to `Layout/EmptyLinesAroundAccessModifier` ([#7059](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/7059)) - [`2aca931`](rubocop/rubocop@2aca931) Add `AllowComments` option to ` Lint/HandleExceptions` - [`c89485f`](rubocop/rubocop@c89485f) [Fix [#6359](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/6359)] Mark `Style/PreferredHashMethods` as unsafe ([#7051](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/7051)) - [`7cf638c`](rubocop/rubocop@7cf638c) [Fix [#7023](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/7023)] Add auto-correction for `Lint/NumberConversion` ([#7054](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/7054)) - [`ed3b9c8`](rubocop/rubocop@ed3b9c8) [Fix [#7042](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/7042)] Remove post install message for RuboCop Performance - [`98ad15f`](rubocop/rubocop@98ad15f) Respect DisabledByDefault for custom cops ([#7013](https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/7013)) - [`72402c0`](rubocop/rubocop@72402c0) Add `unset_nil` option to `ConfigLoader.merge_with_default` - Additional commits viewable in [compare view](rubocop/rubocop@v0.69.0...v0.70.0) </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details> Co-authored-by: dependabot[bot] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See selected text in the screenshot below; this use case is pretty common in this era of js frameworks: give me an empty div that I can plop my app into.
This only happens when the opening and closing tags are on the same line.
Thank you for creating this awesome font.
The text was updated successfully, but these errors were encountered: