Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powerline support in 0.6 #44

Closed
msva opened this issue Sep 5, 2015 · 6 comments
Closed

Powerline support in 0.6 #44

msva opened this issue Sep 5, 2015 · 6 comments

Comments

@msva
Copy link

msva commented Sep 5, 2015

Hi there!
You've announced Powerline support in the 0.6 version, but it seems, they've added a bit buggy:

Also, I've noticed a little offset to the right side for ± symbol (and bottom part of + seems like cutted), and, somewhy, coloured circles (at the right side, which, actually, using same symbol in all three cases) has some positional offsets (yellow one looks like a bit divided at the left side, and red one looks smaller than yellow). I think, that is somehow related to not-really-monospaced nature of the ligatures for that symbols in the font. Maybe, due to some bug during powerline-patching, or so. How do you think?

firacode_artefacts

@tonsky
Copy link
Owner

tonsky commented Sep 5, 2015

± and circles should come from the font, I didn’t draw them. BTW what terminal are you using? Mine ± looks like this:

screen shot 2015-09-06 at 00 07 26

@msva
Copy link
Author

msva commented Sep 5, 2015

I'm using Konsole (at least, it is Konsole on the screenshot).

@alfredbez
Copy link
Contributor

Same issue here (last character - arrow):
bildschirmfoto vom 2016-02-01 15-47-54

$ konsole --version
Qt: 5.4.2
KDE Frameworks: 5.15.0
Konsole: 15.08.0
$ uname -r
4.2.0-25-generic
$ lsb_release -a                                                                                                      !10024
LSB Version:    core-2.0-amd64:core-2.0-noarch:core-3.0-amd64:core-3.0-noarch:core-3.1-amd64:core-3.1-noarch:core-3.2-amd64:core-3.2-noarch:core-4.0-amd64:core-4.0-noarch:core-4.1-amd64:core-4.1-noarch:security-4.0-amd64:security-4.0-noarch:security-4.1-amd64:security-4.1-noarch
Distributor ID: Ubuntu
Description:    Ubuntu 15.10
Release:        15.10
Codename:       wily

@tonsky
Copy link
Owner

tonsky commented Feb 22, 2016

Looks like there’s no easy way to fix it. Powerline is a hack, so expect it to behave like a hack.

Related: powerline/fonts#31

There's just too many factors (different ways of calculating font metrics, different operating systems, different antialiasing technologies, different fonts) to reliably patch a font for every single combination of these factors. You can patch it manually in fontforge or ignore the issue until a fix is found

@tonsky tonsky closed this as completed Feb 22, 2016
@msva
Copy link
Author

msva commented Feb 22, 2016

Powerline itself, as idea, yes, a hacky thing.
Although, they recommends to do a pretty working thing: take the symbols, open FontForge (or any tool you like) and add/fix symbols there.

So, TL;DR: Powerline can brake things when autopatched, but it is possible to just add few symbols of specified look directly into the font (like it done in PragmataPro). Although, yes, it will take few hours or so to do that (in case of FontForge and ttf fonts. And, talking on Fira* — I, actually, have no idea how to edit it under GNU.

@tonsky
Copy link
Owner

tonsky commented Feb 22, 2016

The problem is with triangles only. Fonts in general are not well suited
for pseudographics. E.g. height of the glyph and height of the line are two
different things which are not necessary the same. Problem of powerline is
that they expect that triangle height is equal to line height. You just can
gurantee that. Different systems, terminals, font sizes and font rendering
settings will lead to different line heights/symbols heights proportions.
If I was in charge of powerline I would drop triangles, everything else is
pretty doable and does not create any troubles. Or, if you’re willing to do
so, you can fine tune their height for your specific OS/terminal/font size.

On Tue, Feb 23, 2016 at 2:15 AM Vadim A. Misbakh-Soloviov <
[email protected]> wrote:

Powerline itself, as idea, yes, a hacky thing.
Although, they recommends to do a pretty working thing: take the symbols,
open FontForge (or any tool you like) and add/fix symbols there.

So, TL;DR: Powerline can brake things when autopatched, but it is possible
to just add few symbols of specified look directly into the font (like it
done in PragmataPro). Although, yes, it will take few hours or so to do
that (in case of FontForge and ttf fonts. And, talking on Fira* — I,
actually, have no idea how to edit it under GNU.


Reply to this email directly or view it on GitHub
#44 (comment).

Losangelosgenetics pushed a commit to Losangelosgenetics/FiraCode that referenced this issue Mar 12, 2020
Cache if gem is indexed in Gemstash::Storage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants