-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
am failed #906
Comments
Looks like there is no error message indicating the reason behind the failure? |
I just don't want to see the red color in my output. If something is in red, my brain tries to get rid of it. It says AM failed, so I guess it's failing?
|
Yeah, I know that step AM failed, I was saying that: This step failed, but does not give any reason why it failed. I need to the reason to debug the issue🤔 |
Here's the verbose output:
Isn't it failing at the 609 line of linux.rs? |
There is nothing in line 609, it simply spawns the child process and runs the specified command. So that is not a reason. Could you please try directly executing it in your terminal and give me the output? $ am -u |
|
Could you please do: $ am -u
$ echo $? |
It outputs 1 |
That's the root cause, normally, exit code 0 means success, and non-zero code means failure, so Topgrade treats this 1 as a sign of failure. Gentle ping on @ivan-hc, is this normal, i.e., will AM exit with 1 on success? |
Thanks for being here and for the help! @ivan-hc @aljustiet Does your |
The
The only one that can cause problems is point 1, as the following scenarios can occur:
In both cases this does not prevent the That said, what happens in this issue is not related to "AM" malfunctions. |
Hi, thanks for the reply!
Will "AM" warn the user if the above things happen? |
Normally you would get a notification that the app is updating and a notification that the app is updated... but nothing was updated. My co-worker has about fifty programs installed via AppMan, and in the early days he was doing so much testing that at some point his desktop would fill up with update notifications, but in reality the script that updates the application had simply not contacted the update URL, recognizing that it had changed. However, a couple of months ago we upgraded all the install scripts, adding an |
The above limitations of the github API can be bypassed by adding an alphanumeric key with the You know, the purpose of portable apps (and in particular of AppImages) is to be downloadable from the developer's site or repository. And that's what every script in my repository does. "AM" is a sort of AUR for AppImage packages and other portable apps: it intercepts the URL, executes the dedicated commands depending on whether it is an AppImage, a TAR, a ZIP or a static binary, and finally integrates it into the system, with symbolic links, launchers and icons where necessary. It is not a centralized archive of physical packages (I wish it were like that). |
An example of apps that are difficult to trace: "inkscape", the AppImage is hosted on the official site, and sometimes it happens that the owners change the interface, but also the links or paths where the apps are hosted... and the last time their site was down (they had failed to update the SSL certificates, I think). These are unexpected events that can happen. |
But again, updates for other apps that don't have these problems will continue, in fact the apps update in parallel! It doesn't matter if another app fails. The If And in that case, "AM" would recognize that github.com is down, so it will give an |
Ok, thanks for the detailed explanations! So for Topgrade, we still need to treat this exit code 1 as an error, so nothing to fix here, closing. @aljustiet you need to figure out the issue you have, either you triggered the GH API rate limit, or you have an application whose URL recorded by AM's install script became invalid. Appreciate the help @ivan-hc! Thanks! |
@aljustiet I have just installed zoom, thorium and jan as you have shown in the first comment, no issues here when updating |
What do you get for |
Also, what SHELL are you using? |
I use zsh, but with bash I have the same behavior |
Try |
I tried it, but nothing changed. |
I have this /usr/local/bin/am |
your file is different from my /opt/am/APP-MANAGER reinstall AM
be sure that you have not a file named INSTALL in your working directory |
let do another test then, replace the whole function at line 150
with this
and run |
Still having the same behavior and code 1. |
can you share here both your zshrc and bashrc? |
and maybe also your .profile file, thanks |
@aljustiet just curious, have you got appimagelauncher installed on your system? I ask because it conflicts with AM and other AppImage managers https:/ivan-hc/AM?tab=readme-ov-file#failed-to-open-squashfs-image |
I haven't been able to reproduce the issue. |
|
Yes, I have it installed |
Should I remove it? I use it when there isn't appimage that I want in the AM repos |
remove it and reboot, then try again. In my experience, many users had issues when AppImageLauncher is installed, as you can see from the issues linked in the throubleshot I linked above. Also, AppImageLauncher is no more developed from 2 years, if you need a tool that does the same thing, use GearLever (flatpak) or the |
What appimage isn't in the AM repo btw? AppImage launcher is basically abandoned (the maintainer is still active on github so I don't know why it hasn't been updated), it doesn't support the static runtime so the appimages of Cemu, PCSX2, Zen Browser, etc and all the appimages that Ivan and I make cannot work when appimagelauncher is installed, you cannot even launch them. |
I removed it using pacman and deleted leftovers in ~/.local/share/applications, then rebooted, but still having the same behavior. |
KeePassXC snapshot builds |
Those are like devel builds from here right? Regarding the issue, I would test using appman and install a few apps and then run |
Yes, they're from there. |
Should I replace AM with appman then? |
As long as you are happy with that. I personally find appman better since I'm fine with installing appimages in However this issue is very weird nonetheless, you might wanna try slowly install and remove the apps from AM to AppMan and do am -u on both until you find a possible culprit. |
I removed all apps in am, and it still finished with code 1. |
run |
Yet, it still exits with 1. |
I'm unable to download the bashrc I have seen a lot of stuff in the zshrc file, while .profile is really different from mine. The zshrc file also contain several aliases and @Samueru-sama have you seen the files? EDIT: again, who knows if among all these changes there is something that affects the normal behaviour of AM, and who know if it would work with a "virgin" file |
Yeah seems like some deeper debugging with Anyway I just PRed the devel buidls of @ivan-hc I'm not sure that the shell config files have anything to do here given that appman doesn't have the issue. |
I don't think so. I changed my default shell both on root and user to bash. And rebooted, and ran |
I don't use ZSH, but these are my .bashrc and .profile can you give them a try? |
Should I reboot changing the default shell after copying them into their proper locations? |
yes, you should change the default shell first and reboot, and after that you can do a backup of the four files you have and use just these two. |
But it doesn't work. |
Recap:
@aljustiet its better if I move this issue to the AM repo directly |
Erroneous Behavior
Expected Behavior
shouldn't fail
Steps to reproduce
run topgrade
Problem persists without calling from topgrade
Did you run topgrade through
Remote Execution
If yes, does the issue still occur when you run topgrade directlly in your
remote host
Configuration file (Optional)
https://rentry.co/zcq7rsy9
Additional Details
Arch
Package source
Installation
AUR
Topgrade version (
topgrade -V
)15.0.0
Verbose Output (
topgrade -v
)The text was updated successfully, but these errors were encountered: