Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with Custom Docker locations #15

Open
sr-tennisgazelle opened this issue Jul 19, 2023 · 0 comments
Open

Doesn't work with Custom Docker locations #15

sr-tennisgazelle opened this issue Jul 19, 2023 · 0 comments

Comments

@sr-tennisgazelle
Copy link

This assumes the docker daemon on a server to always be running on unix:///var/run/docker.sock

While this might be fair, this doesn't account for the use case of a custom github runner, where the env var DOCKER_HOST is set.
In cases where it is set (say, i'm running this on ubuntu-latest rather than on custom-server-1), then it will get past the docker build and creation of the container, but it will fail when it gets to the docker run ... cmd as it will have taken DOCKER_HOST as a parameter there.

Basically, it's doomed if you provide the ENV VAR and it's doomed if you do not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant