Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI build for pomelo #265

Open
spookyvision opened this issue Aug 31, 2023 · 4 comments
Open

CI build for pomelo #265

spookyvision opened this issue Aug 31, 2023 · 4 comments

Comments

@spookyvision
Copy link
Contributor

spookyvision commented Aug 31, 2023

came up with this GHA config, verified it works locally with act (when run from the pomelo subdir, with the configuration placed in platforms/pomelo/.github/workflows/). When using the actions-rs/toolchain@v1 action for real, we should remove the toolchain variable - according to the documentation it then picks up what's specified in rust-toolchain.toml. override can then probably also be omitted.

on: [push, pull_request]

name: Pomelo

env:
  TRUNK_VERSION: v0.17.5

jobs:
  build:
    name: Build
    runs-on: ubuntu-latest
    strategy:
      matrix:
        target:
          - wasm32-unknown-unknown
    steps:
      - uses: actions/checkout@v2
      - uses: actions-rs/toolchain@v1
        with:
          toolchain: nightly
          target: ${{ matrix.target }}
          override: true
      - name: trunk build
        run: wget -qO- https:/thedodd/trunk/releases/download/${TRUNK_VERSION}/trunk-x86_64-unknown-linux-gnu.tar.gz | tar -xzf - && ./trunk build --release --public-url="/misc/pomelo"
@spookyvision
Copy link
Contributor Author

spookyvision commented Aug 31, 2023

James, re installing trunk:

We can also use cargo-binstall which also has an action we use for nextest and stuff: https:/cargo-bins/cargo-binstall#faq
e.g. https:/tosc-rs/mnemos/blob/main/.github/workflows/ci.yml#L86-L87

@hawkw
Copy link
Contributor

hawkw commented Sep 4, 2023

@spookyvision do you wanna open a PR to add this?

@spookyvision
Copy link
Contributor Author

I think it makes most sense to postpone this until netlify is migrated - otherwise I would have done so already (or am I mistaken here?). Can't help much with netlify unfortunately, but I did set up GH pages for my personal profile, so I can provide some experience from that corner.

@hawkw
Copy link
Contributor

hawkw commented Sep 4, 2023

Ah, got it. Never mind!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants