Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not reinstall in develop mode without setup.py #2273

Merged
merged 2 commits into from
Dec 29, 2021
Merged

Do not reinstall in develop mode without setup.py #2273

merged 2 commits into from
Dec 29, 2021

Commits on Dec 28, 2021

  1. Do not reinstall in develop mode without setup.py 

    The detection logic for figuring out whether a editable install needs to
be reinstalled only works for setuptools based builds using setup.py.
If setup.py cannot be found the code will fail with an invocation error.
Currently no standard mechanism exists to query a package installed in
editable mode whether it should be reinstalled or not. Hence, this
change skips reinstallation if setup.py cannot be found.

Fixes tox-dev#2197
    @VincentVanlaer @gaborbernat
    VincentVanlaer authored and gaborbernat committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    40f028a View commit details
    Browse the repository at this point in the history

  2. Ensure new envs are marked just_created in tests 

    Otherwise install_pkg will not behave correctly when is_develop=True
    @VincentVanlaer @gaborbernat
    VincentVanlaer authored and gaborbernat committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    8c4d6af View commit details
    Browse the repository at this point in the history