Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always update setuptools before travis run #674

Merged
merged 1 commit into from
Nov 18, 2017

Conversation

gaborbernat
Copy link
Member

resolves #656

@codecov
Copy link

codecov bot commented Nov 18, 2017

Codecov Report

Merging #674 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #674   +/-   ##
=======================================
  Coverage   90.73%   90.73%           
=======================================
  Files          11       11           
  Lines        2363     2363           
  Branches      395      395           
=======================================
  Hits         2144     2144           
  Misses        144      144           
  Partials       75       75

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa71b8e...012790c. Read the comment docs.

@gaborbernat gaborbernat merged commit 67fa228 into tox-dev:master Nov 18, 2017
Copy link

@cryvate cryvate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be setuptools instead of six?

@gaborbernat
Copy link
Member Author

@cryvate technically this is a pip issue, :-) and the underlying issue is already with six (which is a dependency of setuptools), so here I've treated just the bad part :-)

@cryvate
Copy link

cryvate commented Nov 19, 2017

@gaborbernat thanks, I didn't realise that was what was happening, for others interested, see pypa/setuptools#964

@rpkilby
Copy link
Member

rpkilby commented Nov 19, 2017

Hi @gaborbernat - I think you need to add the -U flag to the six install. If you look at the build output, it shows that the requirement is already satisfied (output) and noops. It doesn't upgrade until the tox install.

@rpkilby
Copy link
Member

rpkilby commented Nov 19, 2017

As evidence of this, see this build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation failures with setuptools 34 & 35
3 participants