Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix][UMA] Protect target registration (#13624) #2

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Conversation

tqchen
Copy link
Owner

@tqchen tqchen commented Feb 20, 2023

This PR address fixes for UMA target registration.

Changes:

  • Incorporates all proposed fixes from mentioned PR #12731
  • Address test case concerns and discussions from PR #12731
  • NEW: Already exiting target cannot be created, explicit error on this.
  • NEW: Attributes having special/reserved scope cannot be created explicitly.

It also address proper test cases for all the above.

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

This PR address fixes for UMA target registration.
* Fix the doc issue apache#13304
* Continues stalled PR apache#12731

Changes:
* Incorporates all proposed fixes from mentioned [PR apache#12731](apache#12731)
* Address test case concerns and discussions from [PR apache#12731](apache#12731)
* **NEW:** Already exiting target cannot be created, explicit error on this.
* **NEW:** Attributes having special/reserved scope cannot be created explicitly.

It also address proper test cases for all the above.

Signed-off-by: tqchen <[email protected]>
@tqchen tqchen merged commit 7002557 into v11 Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants