Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/limitとoffsetを暫定でつける #187

Merged
merged 1 commit into from
Jun 24, 2024
Merged

fix/limitとoffsetを暫定でつける #187

merged 1 commit into from
Jun 24, 2024

Conversation

mehm8128
Copy link
Member

@mehm8128 mehm8128 commented Jun 21, 2024

traPtitech/Jomon#762 でlimitとoffsetがついてmainで壊れてたので修正
limitが100で、offsetが0になるように暫定で設定した
mockServiceWorker.jsはnpm iしたら更新されたので更新してある(自動生成)
あとでページングをちゃんと書いて、2ページ目クリックしたときはoffsetを10にする、とかってした方がいいけどページネーションコンポーネントをそこそこ書き換える必要が出てきそうなので一旦issueだけ立てておいて暫定処置

Copy link
Contributor

@reiroop reiroop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

了解です

@mehm8128 mehm8128 merged commit da83a8e into main Jun 24, 2024
6 checks passed
@mehm8128 mehm8128 deleted the fix/type_error branch June 24, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants