Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transactionsにlimit, offsetをつける #711

Closed
mehm8128 opened this issue Apr 9, 2023 · 4 comments · Fixed by #762
Closed

transactionsにlimit, offsetをつける #711

mehm8128 opened this issue Apr 9, 2023 · 4 comments · Fixed by #762
Labels
enhancement New feature or request v2 About Jomon version2

Comments

@mehm8128
Copy link
Member

mehm8128 commented Apr 9, 2023

現状多分全部取ってきますよね
部費納入とかで毎回300くらい作成されるならやばい気がします
requestにもつけた方がいいかも？
@mehm8128 mehm8128 added enhancement New feature or request v2 About Jomon version2 labels Apr 9, 2023
@mehm8128 mehm8128 mentioned this issue May 11, 2024
Closed
@H1rono
Copy link
Member

H1rono commented May 24, 2024

これ、GET /transactionsにlimitとoffsetのクエリをつけるってことであってますか？ @mehm8128

@mehm8128
Copy link
Member Author

合ってます

@H1rono
Copy link
Member

H1rono commented May 26, 2024

  • swagger.yamlに加筆
  • API実装を修正
  • クエリ部分も
  • テストは書かなくてもいい(good first issueにできる)

@H1rono H1rono mentioned this issue Jun 7, 2024
Merged
@mehm8128
Copy link
Member Author

これrequestもお願いしたいです

@H1rono H1rono mentioned this issue Jun 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request v2 About Jomon version2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Transactions query traPtitech/Jomon
2 participants
@H1rono @mehm8128