Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lintのルール増やす #784

Merged
merged 13 commits into from
Jul 23, 2024
Merged

golangci-lintのルール増やす #784

merged 13 commits into from
Jul 23, 2024

Conversation

H1rono
Copy link
Member

@H1rono H1rono commented Jul 19, 2024

close #766

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 38.30846% with 124 lines in your changes missing coverage. Please review.

Project coverage is 25.83%. Comparing base (5c20e25) to head (9848a4f).

Files Patch % Lines
service/webhook.go 0.00% 40 Missing ⚠️
router/middleware.go 0.00% 22 Missing ⚠️
router/router.go 0.00% 19 Missing ⚠️
router/auth.go 0.00% 16 Missing ⚠️
router/transaction.go 46.15% 7 Missing ⚠️
router/request.go 83.33% 6 Missing ⚠️
model/model.go 0.00% 3 Missing ⚠️
router/file.go 0.00% 3 Missing ⚠️
storage/swift.go 0.00% 3 Missing ⚠️
testutil/random/ramdom.go 0.00% 3 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #784      +/-   ##
==========================================
- Coverage   25.84%   25.83%   -0.01%     
==========================================
  Files         148      148              
  Lines       26976    27096     +120     
==========================================
+ Hits         6972     7001      +29     
- Misses      19127    19218      +91     
  Partials      877      877              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@H1rono H1rono marked this pull request as ready for review July 23, 2024 07:52
@H1rono H1rono merged commit 1db6bd3 into v2 Jul 23, 2024
6 of 7 checks passed
@H1rono H1rono deleted the more-golangci-lint branch July 23, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

golangci-lint
1 participant