フッターの表示年を変更した #124
Merged
フッターの表示年を変更した #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehm8128
approved these changes
May 21, 2024
There was a problem hiding this comment.
https:/traPtitech/Ghost-Theme-2020/blob/6384c9f4a44ae3c1b326f4d569e296674bf5d97e/assets/js/app.js#L56
trap.jpも同じような感じで入れてるので問題なさそうです
ちょっと調べた感じ、「発行年-更新年」でもいいし、発行年だけでもいいらしいです(発行年って2015になるのか、公開する2024になるのかどっちなんだろ)
src/components/Layout/PageFooter.vue
Outdated
Comment on lines
2
to
3
| const date = new Date() | ||
| const year = date.getFullYear() |
There was a problem hiding this comment.
分けなくてもよさそうです
Suggested change
| const date = new Date() | |
| const year = date.getFullYear() | |
| const updatedYear= new Date().getFullYear() |
|
なるほど..... |
|
フロントで更新年を計算していいのか微妙だから消しておくのが無難、という話なだけで静的に設定しておくとかなら問題ないとは思います |
|
わかりました |
mehm8128
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #94