Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/検索ボックスを修正 #149

Merged
merged 1 commit into from
Jun 16, 2024
Merged

fix/検索ボックスを修正 #149

merged 1 commit into from
Jun 16, 2024

Conversation

mehm8128
Copy link
Member

close #142

  • 通信バグってたやつ
  • sp時にロゴをアイコンだけに
  • type='search'に

@mehm8128 mehm8128 requested a review from Pugma June 10, 2024 14:56
@mehm8128 mehm8128 self-assigned this Jun 10, 2024
@mehm8128 mehm8128 changed the title 検索ボックスを修正 fix/検索ボックスを修正 Jun 10, 2024
Copy link
Collaborator

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!
一点だけ確認お願いします!

@@ -6,7 +6,7 @@ import useQuery from '/@/lib/query'
import apis from '/@/lib/apis'

const search = useQuery('q')
const users = (await apis.getUsers(false, search.value)).data
const users = (await apis.getUsers(undefined, search.value)).data
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここ編集の前後で動作が変わっていない気がします

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本番に繋いだときに前に言ってたようにサーバー側のエラーになるので、指定しないようにしました

Copy link
Collaborator

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません、遷移先のリンクが同じでapiリクエストだけ変更していたのを忘れてました!
この変更で大丈夫ですありがとうございました

@mehm8128 mehm8128 merged commit 8fcf79b into master Jun 16, 2024
8 checks passed
@mehm8128 mehm8128 deleted the fix/search_input branch June 16, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getUsersでincludeSuspendedの指定をundefinedにする
2 participants