Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated theme is missing the default shopify cart template #53

Closed
jibinycricket opened this issue May 27, 2021 · 1 comment · Fixed by #54
Closed

Generated theme is missing the default shopify cart template #53

jibinycricket opened this issue May 27, 2021 · 1 comment · Fixed by #54
Labels
bug Something isn't working released

Comments

@jibinycricket
Copy link
Contributor

Current Behavior

After running the nx generate @trafilea/nx-shopify:theme <theme-name> command, the cart template directory, which is part of the default shopify templates is missing. Without it the cart page returns a 404

Expected Behavior

After running the nx generate @trafilea/nx-shopify:theme <theme-name> command, the src/theme/templates/cart should also be generated along with

cart.liquid.template
cart.template.scss.template
cart.template.spec.ts.template
cart.template.ts.template

Steps to Reproduce

  1. Run nx generate @trafilea/nx-shopify:theme <theme-name> in the CLI
  2. Verify that src/theme/templates/cart doesn't exist

Environment

  Node : 14.17.0
  OS   : linux x64
  npm  : 6.14.13
  
  nx : Not Found
  @nrwl/angular : Not Found
  @nrwl/cli : 12.3.4
  @nrwl/cypress : Not Found
  @nrwl/devkit : 12.3.4
  @nrwl/eslint-plugin-nx : Not Found
  @nrwl/express : Not Found
  @nrwl/jest : 12.0.8
  @nrwl/linter : 12.3.4
  @nrwl/nest : Not Found
  @nrwl/next : Not Found
  @nrwl/node : Not Found
  @nrwl/react : Not Found
  @nrwl/schematics : Not Found
  @nrwl/tao : 12.3.4
  @nrwl/web : Not Found
  @nrwl/workspace : 12.3.4
  @nrwl/storybook : Not Found
  @nrwl/gatsby : Not Found
  typescript : 4.2.4
@jibinycricket jibinycricket added the bug Something isn't working label May 27, 2021
jibinycricket pushed a commit to jibinycricket/nx-shopify that referenced this issue May 31, 2021
feat(theme): adds the cart template and its corresponding files when …
1f66126 
…a theme gets generated

ISSUES CLOSED: trafilea#53
jibinycricket pushed a commit to jibinycricket/nx-shopify that referenced this issue May 31, 2021
fix(theme): fixed failed e2e test
23e2eed 
ISSUES CLOSED: trafilea#53
jibinycricket pushed a commit to jibinycricket/nx-shopify that referenced this issue May 31, 2021
cleanup(theme): removed newline
f344281 
ISSUES CLOSED: trafilea#53
@jibinycricket jibinycricket mentioned this issue May 31, 2021
Merged
sebastiandg7 added a commit that referenced this issue Jun 2, 2021
@sebastiandg7
chore(release): nx-shopify-v1.4.0 [skip ci]
4e32f31 
# [1.4.0](v1.3.0...v1.4.0) (2021-06-02)

### Bug Fixes

* **theme:** fixed failed e2e test ([23e2eed](23e2eed)), closes [#53](#53)

### Features

* **theme:** adds the cart template and its corresponding files when a theme gets generated ([1f66126](1f66126)), closes [#53](#53)
sebastiandg7 added a commit that referenced this issue Jun 2, 2021
@sebastiandg7
chore(release): nx-shopify-v1.4.0 [skip ci]
8014501 
# [1.4.0](v1.3.0...v1.4.0) (2021-06-02)

### Bug Fixes

* **theme:** fixed failed e2e test ([23e2eed](23e2eed)), closes [#53](#53)

### Features

* **theme:** adds the cart template and its corresponding files when a theme gets generated ([1f66126](1f66126)), closes [#53](#53)
sebastiandg7 added a commit that referenced this issue Jun 2, 2021
@sebastiandg7
chore(release): nx-shopify-v1.4.0 [skip ci]
05270aa 
# [1.4.0](v1.3.0...v1.4.0) (2021-06-02)

### Bug Fixes

* **theme:** fixed failed e2e test ([23e2eed](23e2eed)), closes [#53](#53)

### Features

* **theme:** adds the cart template and its corresponding files when a theme gets generated ([1f66126](1f66126)), closes [#53](#53)
@sebastiandg7
Copy link
Contributor

🎉 This issue has been resolved in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(theme): adds the cart template and its corresponding files jibinycricket/nx-shopify
2 participants
@jibinycricket @sebastiandg7