Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix navigating to invalid page issue[#584] #585

Merged

Conversation

oguzhancvdr
Copy link
Contributor

What does this PR do?

  • This pr fix navigating users to invalid page when see electra bikes button is clicked on the home page.

What issues does this PR fix or reference?

#584

The PR fulfills these requirements:

  • Tests for the proposed changes have been added/updated.
  • Code linting and formatting was performed.

Functionality Before

https://watch.screencastify.com/v/eerVKw2KVh5wQv38MwRZ

Functionality After

https://watch.screencastify.com/v/VIEwKm6jbQS7CwbVAzF0

@oguzhancvdr oguzhancvdr requested a review from a team as a code owner September 2, 2023 14:47
@pozil
Copy link
Contributor

pozil commented Sep 20, 2023

Good catch @oguzhancvdr and thanks for the fix.

@pozil pozil merged commit c9ccc44 into trailheadapps:main Sep 20, 2023
4 of 5 checks passed
@oguzhancvdr
Copy link
Contributor Author

Good catch @oguzhancvdr and thanks for the fix.

You are welcome @pozil 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants