fix: decorator_call_expression type arguments #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not realise that the parser was this long, maybe it should not be included in the PR, let me know what you think. |
|
@amaanq could you review this one please ? |
|
@hendrikvanantwerpen maybe ? (sorry to disturb if I do, I just feel like it could be nice to fix this) |
hendrikvanantwerpen
approved these changes
Jun 18, 2024
amaanq
force-pushed
the
master
branch
2 times, most recently
from
3f27522
to
2f181af
Compare
|
yeah sorry for the delay @nohehf, but thanks for the PR! |
|
Thanks for merging @amaanq (and thanks for the review @hendrikvanantwerpen) ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #283, I added a test case for what was failing before, that now passes.