fix(suite): fix coinjoin pausing with several ongoing sessions #6934
Conversation
| import { COINJOIN_PHASE_MESSAGES } from '@suite-constants/coinjoin'; | ||
| import { | ||
| calculateSessionProgress, | ||
| getPhaseTimerFormat, | ||
| getSessionDeadlineFormat, | ||
| } from '@wallet-utils/coinjoinUtils'; | ||
| import { useDispatch } from 'react-redux'; |
There was a problem hiding this comment.
I know it's not a first usage, but would be nice to discuss what is the current preferred way https://www.notion.so/satoshilabs/Redux-b0a4c3b7e71b499a8d592fb44cd794fe#31445739321c401dbf1d2396ee4ad3bc
There was a problem hiding this comment.
Far from the first one, I've been using it for several months, I think 😅 Also, the mobile team has been using it for a while. But we can definitely discuss it and compare pros and cons.
packages/suite/src/components/wallet/CoinjoinSummary/CoinjoinStatus.tsx
Outdated
Show resolved
Hide resolved
| @@ -8,4 +8,4 @@ | |||
|
|
|||
| Resolve <!--- link the issue here --> | |||
|
|
|||
| ## Screenshots (if appropriate): | |||
| ## Screenshots: | |||
There was a problem hiding this comment.
This looks like totally unrelated to this PR.
There was a problem hiding this comment.
It is, I think this change is not really worth CI time...
There was a problem hiding this comment.
Totally agree, that unrelated things should be in separate PRs. No need to change it for this PR, but for the future it's better not to save the CI time that much.
dahaca
force-pushed
the
fix/pausing-cj
branch
from
76c7b1d
to
f2e7210
Compare
|
@dahaca please check the failing unit test |
dahaca
force-pushed
the
fix/pausing-cj
branch
from
f2e7210
to
7d597c6
Compare
Description
Related Issue
Resolve #6812
Screenshots:
Screen.Recording.2022-11-16.at.15.42.02.mov