Skip to content
This repository has been archived by the owner on Dec 11, 2023. It is now read-only.

Adding CA Certificate for RedisBroker #130

Merged
merged 2 commits into from
Mar 25, 2023

Conversation

coding-trees
Copy link
Contributor

2nd part to adding CA certificate support for RedisBroker as described in this issue #129

@coding-trees
Copy link
Contributor Author

Hi @odacremolbap - let me know if there are any other docs or repos that will need to be updated with information re: CA Certificates. Thanks

Copy link
Member

@odacremolbap odacremolbap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your PRs @coding-trees
This is looking good.

I asked for a couple of nits.

At one of them I am suggesting to validate that CA Certificate is not informed alongside Skip Verify. That would be done here and would probably look like this:

	if ra.TLSCACertificate != "" && ra.TLSSkipVerify {
		msg = append(msg, "only one of skip verify or CA certificate can be informed")
	}

pkg/backend/impl/redis/cmd.go Outdated Show resolved Hide resolved
pkg/backend/impl/redis/redis.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@coding-trees
Copy link
Contributor Author

Hi @odacremolbap - Thank you for the review and feedback, I believe I have applied all of the changes you have suggested - if there is anything missing or anything is still kind of "off" please let me know. I don't mind any and all suggestions, feel free to nit pick; just want to make sure the changes are up to snuff.

@odacremolbap odacremolbap merged commit a67bcae into triggermesh:main Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants