[fix] using hash symbol in search query causes broken display #110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When submitting a search containing the hash symbol the query request is truncated and you get JSON used as text result.
Sample query:
the #1 problem
Expected AJAX query:
s?q=the%20%231%20problem&l=20&sl=300&search_type=auto&ajax=true
Actual query:
s?q=the
The issue comes because without encoding uri parameter the query becomes:
/s?q=the #1 problem&l=20&sl=300&search_type=auto&ajax=true
And everything after the hash symbol is removed.
This introduces: encodeURIComponent() so everything is encoded before making the request.
See:
https://developer.mozilla.org/es/docs/Web/JavaScript/Referencia/Objetos_globales/encodeURIComponent