Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sems-scotch/6.0.3/nopthread_64bit_parallel TPL to automated PR builds of Trilinos #2065

Closed
1 task
bartlettroscoe opened this issue Dec 7, 2017 · 3 comments
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. Framework tasks Framework tasks (used internally by Framework team) MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. pkg: ShyLU

Comments

@bartlettroscoe
Copy link
Member

CC: @trilinos/framework, @trilinos/zoltan, @trilinos/zoltan2, @trilinos/shylu

Motivation and Context

It would be advantageous to add testing of Trilinos with the Scotch TPL to the automated PR testing builds (and perhaps other builds) that the Trilinos Framework team runs. Scotch is an important TPL used by several customers and developers. It is directly used in the Trilinos packages Zoltan, Zoltan2, and ShyLU as shown by:

$ find . -name Dependencies.cmake -exec grep -nHi scotch {} \;
...
./packages/zoltan2/cmake/Dependencies.cmake:6:SET(LIB_OPTIONAL_DEP_TPLS METIS PaToH ParMETIS PuLP Scotch AMD CCOLAMD OVIS TopoManager rcalib)
./packages/zoltan2/cmake/Dependencies.cmake:8:SET(TEST_OPTIONAL_DEP_TPLS METIS PaToH ParMETIS PuLP Scotch AMD CCOLAMD OVIS TopoManager rcalib)
./packages/shylu/shylu_node/basker/cmake/Dependencies.cmake:5:SET(LIB_REQUIRED_DEP_TPLS Scotch)
./packages/shylu/shylu_node/basker/cmake/Dependencies.cmake:7:SET(TEST_REQUIRED_DEP_TPLS Scotch)
./packages/shylu/shylu_node/tacho/cmake/Dependencies.cmake:6:SET(LIB_OPTIONAL_DEP_TPLS METIS Scotch Cholmod HWLOC HYPRE MKL LAPACK BLAS Pthread QTHREAD VTune)
./packages/zoltan/cmake/Dependencies.cmake:6:SET(LIB_OPTIONAL_DEP_TPLS MPI METIS ParMETIS PaToH Scotch Zlib CCOLAMD OVIS)

Story #2051 demonstrated that the BASIC tests in the PT packages in Trilinos pass using the SEMS-provided TPL module sems-scotch/6.0.3/nopthread_64bit_parallel. In fact, the CI Build linked to from:

now enables that Scotch TPL. Since the automated PR builds of Trilinos do not enable Scotch, branches that pass the automated PR testing may break that other TPL build which enables Scotch. Therefore, to help protect that CI build and Trilinos developers and customers that rely on Scotch in Trilinos, it would be good to add Scotch to the list of enabled TPLs in the automated PR builds (and perhaps in other builds as well using the SEMS env).

Definition of Done

  • At least one of the automated PR builds of Trilinos enables the sems-scotch/6.0.3/nopthread_64bit_parallel TPL.

Related Issues

@mhoemmen
Copy link
Contributor

mhoemmen commented Dec 7, 2017

@rrdrake @prwolfe

@github-actions
Copy link

github-actions bot commented May 1, 2021

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label May 1, 2021
@github-actions
Copy link

github-actions bot commented Jun 2, 2021

This issue was closed due to inactivity for 395 days.

@github-actions github-actions bot added the CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. label Jun 2, 2021
@github-actions github-actions bot closed this as completed Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. Framework tasks Framework tasks (used internally by Framework team) MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. pkg: ShyLU
Projects
None yet
Development

No branches or pull requests

3 participants