Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teuchos_ObjectBuilder_unsetParameterList_UnitTest fails with gcc 6.2 on Mac OS X #907

Closed
tjfulle opened this issue Dec 6, 2016 · 2 comments
Closed

Teuchos_ObjectBuilder_unsetParameterList_UnitTest fails with gcc 6.2 on Mac OS X #907

tjfulle opened this issue Dec 6, 2016 · 2 comments
Labels
pkg: Teuchos Issues primarily dealing with the Teuchos Package

Comments

@tjfulle
Copy link
Contributor

tjfulle commented Dec 6, 2016

@trilinos/teuchos

The test Teuchos_ObjectBuilder_unsetParameterList_UnitTest fails on Mac OS X with gcc 6.2. In packages/teuchos/parameterlist/test/ObjectBuilder/ObjectBuilder_UnitTests.cpp, there are some notes about some of the tests failing on gcc 4.8 and gcc 5.3, so the tests are shielded by compile time #ifdefs from those compilers. If I add gcc 6.2 to the list of failing compilers as:

#if !(__GNUC__ == 4 && __GNUC_MINOR__ == 8) && !(__GNUC__ == 5 && __GNUC_MINOR__ == 3) && !(__GNUC__ == 6 && __GNUC_MINOR__ == 2)

The test passes.
@mhoemmen mhoemmen added the pkg: Teuchos Issues primarily dealing with the Teuchos Package label Dec 7, 2016
@bartlettroscoe
Copy link
Member

@tjfulle, I think this is similar to #831 which I recently fixed. Please go ahead and fix and test locally and then push with the checkin-test-sems.sh on a RHEL 6 machine. If you don't have access to such as machine, just push the fix to a branch and I will test and push it for you for now or you can use my machine crf450 to do the remote pull, test, and push process to safely push this. Once you get your CEE LAN machine, then you can push these yourself. Just make sure and reference #907 in your commit message.

tjfulle added a commit to tjfulle/Trilinos that referenced this issue Dec 7, 2016
@tjfulle
Resolution for Issue trilinos#907, Teuchos test fails with GCC 6.2 on…
d98d7ce 
… Mac OSX

Issue trilinos#907 is similar to Issue trilinos#831 and the fix is the same.  See the
discussion in trilinos#831 for more details.

Tests: standard checkin-test.sh tests run, but on a Mac, so there are
many test failures.  Tests should be run on a RHEL 6 machine with SEMS
before merging PR.
@tjfulle tjfulle mentioned this issue Dec 7, 2016
Closed
bartlettroscoe pushed a commit that referenced this issue Dec 7, 2016
@tjfulle @bartlettroscoe
Resolution for Issue #907, Teuchos test fails with GCC 6.2 on Mac OSX
e312736 
Issue #907 is similar to Issue #831 and the fix is the same.  See the
discussion in #831 for more details.

Tests: standard checkin-test.sh tests run, but on a Mac, so there are
many test failures.  Tests should be run on a RHEL 6 machine with SEMS
before merging PR.
@bartlettroscoe
Copy link
Member

I merged and rebased the fixing commit and pushed it as the commit e312736 to the 'develop' branch.

This is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkg: Teuchos Issues primarily dealing with the Teuchos Package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mhoemmen @tjfulle @bartlettroscoe