Tpetra: Fix for Issue #1752 #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug found while investigating trilinos#1752. It also adds a new test that should prevent a regression in the future. Build/Test Cases Summary Enabled Packages: TpetraCore Disabled Packages: PyTrilinos,Claps,TriKota Enabled all Forward Packages 0) MPI_RELEASE_DEBUG_SHARED_PT => passed: passed=1536,notpassed=0 (110.84 min)
mhoemmen
approved these changes
Oct 10, 2017
| @@ -2823,6 +2866,7 @@ namespace Tpetra { | |||
| size_t j = startsTo_[p]; | |||
| size_t numPacketsTo_p = 0; | |||
| for (size_t k = 0; k < lengthsTo_[p]; ++k, ++j) { | |||
| numPacketsTo_p += numExportPacketsPerLID[j]; | |||
There was a problem hiding this comment.
Note to self: This is the line that fixes the bug :-) .
There was a problem hiding this comment.
(The changes to other lines are important because they help with debug output, but they do not actually fix the issue.)
|
Thanks for looking @mhoemmen! |
|
Thanks @tjfulle !!! Fantastic job!!! :-D |
|
Thanks, @tjfulle |
|
Thanks @tjfulle ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug found while investigating #1752. It also adds a new
test that should prevent a regression in the future.
Build/Test Cases Summary
Enabled Packages: TpetraCore
Disabled Packages: PyTrilinos,Claps,TriKota
Enabled all Forward Packages
0) MPI_RELEASE_DEBUG_SHARED_PT => passed: passed=1536,notpassed=0 (110.84 min)