Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bddc #3738
Bddc #3738
Changes from 7 commits
9b55f6a
bbacfaa
8778b75
d25fd8e
609475b
8ff0bd4
c33cc56
4095668
0c3e77c
c8b9066
3b560f9
4cf656c
a4acb62
7ad346b
bd61574
d81789b
71bdeb9
e9c623d
3176884
cb29cee
e8c96c6
8520356
54a2ef2
6bb29b6
abf9134
334be82
ecb3d27
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're using Tpetra in this example, you would need to check whether
GO=long
is enabled. If you don't really depend onGO=long
, it would be better just to depend on Tpetra's default global ordinal type:typedef Tpetra::Map<>::global_ordinal_type GO;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed your suggestion and am now using Tpetra's default global ordinal type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is how you can ensure that you always get a 64-bit global ordinal type:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once Tpetra finishes deprecation and removal of the GlobalOrdinal template parameter, you should be able to remove the macros and just have one typedef for
GO
and astatic_assert
. The typedef for GO would look like this:using GO = Tpetra::Map::global_ordinal_type;
. Right now, since the template parameters are still there, you could writeusing GO = Tpetra::Map<>::global_ordinal_type;
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
std::vector
of raw pointer suggests a memory leak to me. Do those inner pointers get freed / cleaned up at some point?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better or worse, I wanted to have a plain old data interface to BDDC. The pointers actually point to standard vector data that later gets deallocated.