Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tpetra: enable build for HIP backend #8938

Merged
merged 4 commits into from
Apr 2, 2021
Merged

Tpetra: enable build for HIP backend #8938

merged 4 commits into from
Apr 2, 2021

Commits on Mar 30, 2021

  1. Configuration menu
    Copy the full SHA
    5c2b6bd View commit details
    Browse the repository at this point in the history
  2. Changes to make Tpetra compile its test with HIP as the execution space

    WIth these changes MPI, off and hacking the Kokkos::Experiment::HIP::memory_space
    typedef to be Kokkos::Experimental::HIPHostPinnedSpace we get these failures:
    
    124/124 Test #124: TpetraCore_TsqrAdaptor ..........................................   Passed    0.55 sec
    95% tests passed, 5 tests failed out of 124
    Label Time Summary:
    Tpetra    = 147.76 sec*proc (124 tests)
    Total Test time (real) = 147.96 sec
    The following tests FAILED:
             19 - TpetraCore_idot (Subprocess aborted)
             83 - TpetraCore_MatrixMatrix_UnitTests (NUMERICAL)
            121 - TpetraCore_RowMatrixTransposer_test (Subprocess aborted)
            122 - TpetraCore_RowMatrixTransposer_UnitTests (Failed)
            123 - TpetraCore_CrsMatrix_transpose_sortedRows (Failed)
    
    This IS running on the AMD GPU ...
    crtrott authored and brian-kelley committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    f4b4047 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4580345 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2021

  1. Get Tpetra build working on HIP

    - Added explicit instantiation file for FixedHashTable
    - Use HIP/HIPHostPinnedSpace as the KokkosHIPWrapperNode in Tpetra only
      (no kokkos changes)
    - Fix device types in several places to work when the desired device
      memory space isn't the default of the execution space
    - Disabled 3 tests that crash AMD GPUs
    brian-kelley committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    ab82c27 View commit details
    Browse the repository at this point in the history