TL-28813: Add Transaction ID #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -48,6 +48,8 @@ export const tripleliftAdapterSpec = { | |||
| } | |||
| } | |||
|
|
|||
| utils.deepSetValue(data, 'source.tid', bidRequests[0].auctionId); | |||
There was a problem hiding this comment.
Will need to import this on line 1
There was a problem hiding this comment.
We'll actually need to put this inside _buildPostBody because each .transactionId is unique for each adUnit (auctionId is not the correct value to reference).
So deepSetValue into each imp object.
|
closing due to new direction from prebid |
|
we're interested in your thoughts on if source.tid should exist (is imp.ext.tid enough), be request[0].transactionId, or be request.auctionId |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://triplelift.atlassian.net/browse/TL-28813 - conversation screen grab is included in ticket
This PR allows for our bid adapter to pass auction ID to transaction ID. This PR includes 1 test - to check if the data object includes source.tid. We are using the bidRequests[0] similarly to other adapters that pass multiple bid requests.