Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urllib dependency is present when using [grpc, cuda] options #657

Open
bgedik opened this issue May 14, 2024 · 0 comments
Open

urllib dependency is present when using [grpc, cuda] options #657

bgedik opened this issue May 14, 2024 · 0 comments

Comments

@bgedik
Copy link

bgedik commented May 14, 2024

urllib is only used for the http backend based on my look at the code, but the top level requirements.txt list urllib as a dependency. However, it should be only in the requirements_http.txt and not in the top level requirements.txt.

This creates unnecessary conflicts when one only wants to depend on grpc and not http backend. Dependency conflicts like the one reported here: #648

@bgedik bgedik changed the title urllib dependency is present only when using [grpc, cuda] options urllib dependency is present when using [grpc, cuda] options May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant