Replace subprocess.Popen with subprocess.run #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner exit when launching containers in detached mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
Popencreates a non-blocking subprocess. When launching Docker containers in detached mode (-dflag) this causes the container to start and then immediately stop, since the main thread within the container has completed all tasks. In addition, there are no logs or errors generated upon exit.As it is very common to launch containers in detached mode and the
launch_triton_server.pymay be specified as the entry point, usingrunfollows Docker best practices by havingtritonserverrun as the main process (https://docs.docker.com/config/containers/multi-service_container/).