-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Allow plugins to skip nslookup #458
Comments
Second: What about to add an optional function pointer in const int *skip_nslookup; which would
Of course, if the function pointer is This would allow us to remove the special handling and also to solve my problem with Cloudflare round-robin entries. All that said, I understand this is a very specific hook for a very specific situation being added to an entire plugin system. This is just my first idea. Any other suggestions to solve this problem are welcome. |
You're right, this looks like a mess currently. I'm not so sure about the collapsing all.dnsomatic.com into that array though. The first is per provider and the latter is an exception for when a user selects updating all their dns entries for the given provider. (But then again, I'm still a bit off due to this flu I'm dragging along, and I've just woken up :) Anyway, I think your proposal is a good one. The code needs a bit of refactoring, so please go ahead! |
When implementing #454 I found another problem which I left to solve later.
It is related to this code in
cache.c
:My current implementation for Cloudflare round-robin suffers from this problem, too. When passing a cloudflare ID this code tries to
nslookup
it giving the error:and always forcing the update.
It is a small problem, it won't stop the update, but I would like to fix it anyways.
To the best of my understanding there are currently 2 workarounds in the code for this:
read_one()
function (a special handling forall.dnsomatic.com
):My first question would be:
I'm missing something or this special handling for
all.dnsomatic.com
is totally unneeded? Couldn't it just be added to this array?The text was updated successfully, but these errors were encountered: