feat: OIDC4VCI Authorization code flow - Support for Wallet Initiated flow #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… flow Signed-off-by: Mykhailo Sizov <[email protected]>
mishasizov-SK
commented
Jul 14, 2023
| @@ -229,6 +236,186 @@ func (s *Service) RunOIDC4CI(config *OIDC4CIConfig, hooks *Hooks) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func extractWalletInitiatedFlowParams(scopes []string) *walletInitiatedFlowParams { | |||
| for _, scope := range scopes { | |||
| chunks := strings.Split(scope, "||") | |||
There was a problem hiding this comment.
Pass only issuerURL. Do not need to crete combined string that includes claimsEndpoint and credentialTemplateID
mishasizov-SK
commented
Jul 14, 2023
| "scopes": [ | ||
| "openid", | ||
| "profile", | ||
| "https://api-gateway.trustbloc.local:5566/issuer/bank_issuer/v1.0||https://mock-login-consent.example.com:8099/claim-data?credentialType=UniversityDegreeCredential||universityDegreeTemplateID" |
There was a problem hiding this comment.
Do not need to keep claimsEndpoint and templateID as a part of the scope. Only issuerURL.
mishasizov-SK
commented
Jul 14, 2023
Comment on lines
+278
to
+284
| //if parsedURL, err := url.Parse(scope); err != nil || parsedURL.Host == "" { | ||
| // continue | ||
| //} | ||
| chunks := strings.Split(scope, "||") | ||
| if len(chunks) != 3 { | ||
| continue | ||
| } |
There was a problem hiding this comment.
check only if one of the scopes is issuerURL.
mishasizov-SK
commented
Jul 14, 2023
| } | ||
|
|
||
| //todo: make a call to well-known. | ||
| //issuerOidcConfiguration, err := s.getIssuerOIDCConfig(chunks[0]) |
There was a problem hiding this comment.
get issuer issuerOidcConfiguration. If issuerOidcConfiguration.WalletInitiatedAuthFlowSupported - then take credentialURL from issuerOidcConfiguration
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1369 +/- ##
==========================================
- Coverage 87.54% 86.41% -1.14%
==========================================
Files 149 149
Lines 9040 9178 +138
==========================================
+ Hits 7914 7931 +17
- Misses 739 855 +116
- Partials 387 392 +5
☔ View full report in Codecov by Sentry. |
mishasizov-SK
deleted the
feat_OIDC4VCI_Authorization_code_flow_-_Support_for_Wallet_Initiated_flow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.