Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for wallet initiated flow #1370

Merged
merged 23 commits into from
Jul 18, 2023

Conversation

skynet2
Copy link
Member

@skynet2 skynet2 commented Jul 17, 2023

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage: 96.81% and project coverage change: -0.09 ⚠️

Comparison is base (965db5a) 87.54% compared to head (19e03b5) 87.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1370      +/-   ##
==========================================
- Coverage   87.54%   87.46%   -0.09%     
==========================================
  Files         149      153       +4     
  Lines        9040     9172     +132     
==========================================
+ Hits         7914     8022     +108     
- Misses        739      760      +21     
- Partials      387      390       +3     
Impacted Files Coverage Δ
pkg/restapi/v1/common/common.go 100.00% <ø> (ø)
pkg/restapi/v1/oidc4ci/controller.go 90.65% <92.30%> (-0.34%) ⬇️
pkg/service/oidc4ci/oidc4ci_service.go 94.60% <95.23%> (-0.64%) ⬇️
...bility/tracing/wrappers/oidc4ci/oidc4ci_wrapper.go 85.71% <100.00%> (ø)
pkg/restapi/v1/issuer/controller.go 88.91% <100.00%> (+0.11%) ⬆️
pkg/restapi/v1/util/validate.go 100.00% <100.00%> (ø)
...g/service/oidc4ci/oidc4ci_service_exchange_code.go 100.00% <100.00%> (ø)
...rvice/oidc4ci/oidc4ci_service_initiate_issuance.go 92.77% <100.00%> (+0.16%) ⬆️
...service/oidc4ci/oidc4ci_service_store_auth_code.go 100.00% <100.00%> (ø)
pkg/service/oidc4ci/regex.go 100.00% <100.00%> (ø)
... and 1 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skynet2 skynet2 marked this pull request as ready for review July 18, 2023 13:42
docs/v1/openapi.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@DRK3 DRK3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

Signed-off-by: Stas D <[email protected]>
@skynet2 skynet2 requested a review from DRK3 July 18, 2023 15:38
Signed-off-by: Stas D <[email protected]>
Signed-off-by: Stas D <[email protected]>
Signed-off-by: Stas D <[email protected]>
Signed-off-by: Stas D <[email protected]>
Signed-off-by: Stas D <[email protected]>
package oidc4ci

const (
WalletInitFlowClaimRegex = `(https|http):\/\/.*\/issuer\/(.*?)\/(.*)$`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we have this regex?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one of the scopes which we receive /odic/authorize endpoint is link to our issuer profile. this regex is used to identify that scope and parse it @sudeshrshetty

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we just need to check if it URL or not, issuer term should be removed

@sudeshrshetty sudeshrshetty merged commit fee7f49 into trustbloc:main Jul 18, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants