Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve dependencies that require afgo #1408

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

Moopli
Copy link
Contributor

@Moopli Moopli commented Sep 7, 2023

  • port aws wrapper from trustbloc/kms
  • remove orb usage from VCS

@cla-bot cla-bot bot added the cla-signed label Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 87.04% and project coverage change: +0.18% 🎉

Comparison is base (326d923) 85.17% compared to head (3765569) 85.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1408      +/-   ##
==========================================
+ Coverage   85.17%   85.36%   +0.18%     
==========================================
  Files         159      162       +3     
  Lines        9782    10151     +369     
==========================================
+ Hits         8332     8665     +333     
- Misses       1052     1081      +29     
- Partials      398      405       +7     
Files Changed Coverage Δ
component/profile/reader/file/creator.go 0.00% <0.00%> (ø)
component/profile/reader/file/reader.go 13.19% <0.00%> (+0.26%) ⬆️
pkg/kms/arieskms.go 74.50% <ø> (ø)
pkg/kms/aws/service_mocks.go 77.84% <77.84%> (ø)
pkg/kms/aws/service.go 98.92% <98.92%> (ø)
cmd/vc-rest/startcmd/configuration.go 89.13% <100.00%> (+3.41%) ⬆️
pkg/kms/aws/opts.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@Moopli Moopli force-pushed the orb-aws branch 2 times, most recently from 73a5bc5 to 737b53b Compare September 7, 2023 22:32
@Moopli Moopli marked this pull request as ready for review September 7, 2023 22:34
- port aws wrapper from trustbloc/kms
- remove orb usage from VCS

Signed-off-by: Filip Burlacu <[email protected]>
@fqutishat fqutishat merged commit 368c3c1 into trustbloc:main Sep 8, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants