Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OID4VP ID2 updates #1728

Merged
merged 1 commit into from
Jun 10, 2024
Merged

feat: OID4VP ID2 updates #1728

merged 1 commit into from
Jun 10, 2024

Conversation

aholovko
Copy link
Contributor

@aholovko aholovko commented Jun 7, 2024

No description provided.

Signed-off-by: Andrii Holovko <[email protected]>
@cla-bot cla-bot bot added the cla-signed label Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 91.93548% with 10 lines in your changes missing coverage. Please review.

Project coverage is 85.92%. Comparing base (dcc7b2a) to head (00bf219).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/restapi/v1/verifier/controller.go 85.00% 4 Missing and 5 partials ⚠️
pkg/restapi/v1/oidc4vp/controller.go 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1728      +/-   ##
==========================================
+ Coverage   85.90%   85.92%   +0.01%     
==========================================
  Files         172      172              
  Lines       12078    12099      +21     
==========================================
+ Hits        10376    10396      +20     
- Misses       1244     1245       +1     
  Partials      458      458              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fqutishat fqutishat merged commit b2df12a into trustbloc:main Jun 10, 2024
10 checks passed
@aholovko aholovko deleted the oid4vp_id2 branch June 10, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants