This repository has been archived by the owner on Jul 28, 2018. It is now read-only.
Fix page caching and lifecycle events #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix turbolinks#551. Partial replacement broke the page cache by caching body.outerHTML (losing all DOM state in the process) instead of the body element itself. This commit brings back the old behavior, with the following gotcha: when a partial replacement is performed, we remove the current page from the cache, since the body element will not change and there is no simple way for us to bring back the changed nodes. Additionally: - page:after-remove on body elements now triggers on cache eviction (since we don't want to lose DOM state) - to avoid triggering page:load on the same body elements more than once, a partial replacement now triggers the page:partial-load event
|
Docs in #576. |
dhh
added a commit
that referenced
this pull request
Jul 20, 2015
Fix page caching and lifecycle events
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #551.
Partial replacement broke the page cache by caching
body.outerHTML(losing all DOM state in the process) instead of the body element itself.This PR brings back the old behavior, with the following drawback: when a partial replacement is performed, instead of caching the current page, 1) we don't cache it and 2) we remove it from the cache if it was there already (previous visit), since 1) the body element will not change and there is no simple way for us to bring back the changed nodes, 2) we don't want to restore an outdated version of the page.
Also:
page:after-removeon body elements now triggers on cache eviction (since we don't want to lose DOM state when restoring pages from the cache)page:loadon the same body element more than once, which would be a major breaking change, partial replacements now trigger thepage:partial-loadevent.@dhh @reed @kristianpd @WojtekKruszewski