Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

46 replace current navigation by go_router #282

Merged
merged 18 commits into from
May 11, 2022
Merged

46 replace current navigation by go_router #282

merged 18 commits into from
May 11, 2022

Conversation

tusharlock10
Copy link
Owner

@tusharlock10 tusharlock10 commented May 10, 2022 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • App has been built and tested (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • PR is linked to the GitHub issue that is being addressed
  • Appropriate labels have been added to the PR

Type of PR

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactor
  • Build/ Workflow
  • Documentation
  • Other

Issue resolution

Tell us about how the fix/ feature resolves the linked issue

  • Added go_router for navigation
  • Added support for direct linking in web

Breaking change

This is a fucking rewrite of the app not just a breaking change

  • Yes
  • No

@tusharlock10 tusharlock10 added the feature Some new feature is implemeted label May 10, 2022
@tusharlock10 tusharlock10 self-assigned this May 10, 2022
@tusharlock10 tusharlock10 linked an issue May 10, 2022 that may be closed by this pull request
replace current navigation by go_router #46
Closed
@netlify
Copy link

netlify bot commented May 10, 2022 •
edited
Loading

✅ Deploy Preview for paladinsedge ready!

Name Link
🔨 Latest commit 2b3bca2
🔍 Latest deploy log https://app.netlify.com/sites/paladinsedge/deploys/627c1e0a3b67630009d65e78
😎 Deploy Preview https://deploy-preview-282--paladinsedge.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tusharlock10 tusharlock10 marked this pull request as draft May 10, 2022 05:37
@tusharlock10 tusharlock10 marked this pull request as ready for review May 11, 2022 20:19
@tusharlock10 tusharlock10 merged commit 53656a4 into develop May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tusharlock10 tusharlock10

Labels
feature Some new feature is implemeted
Projects
Paladins Edge Client
Status: Closed PRs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace current navigation by go_router
1 participant
@tusharlock10