Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(login): remove compulsory login for new players #411

Merged

Conversation

tusharlock10
Copy link
Owner

new players are can use the app as guest user from the get go

resolves #410

PR Checklist

Please check if your PR fulfills the following requirements:

  • App has been built and tested (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • PR is linked to the GitHub issue that is being addressed
  • Appropriate labels have been added to the PR

Type of PR

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactor
  • Build/ Workflow
  • Documentation
  • Other

Issue resolution

Tell us about how the fix/ feature resolves the linked issue

  • New users can use the app without login
  • Fix filter not clearing when reload

Breaking change

If this is a breaking change (i.e. removing a feature, etc.) that could impact existing users

  • Yes
  • No

new players are can use the app as guest user from the get go

resolves #410
@tusharlock10 tusharlock10 added the feature Some new feature is implemeted label Oct 2, 2022
@tusharlock10 tusharlock10 self-assigned this Oct 2, 2022
@tusharlock10 tusharlock10 merged commit 185094b into develop Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Some new feature is implemeted
Projects
Status: Closed PRs
Development

Successfully merging this pull request may close these issues.

1 participant