Fix synchronized contacts not appearing in some contact apps #7487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
charlag
force-pushed
the
dev-mail
branch
2 times, most recently
from
c763e8c
to
def698a
Compare
charlag
reviewed
Aug 30, 2024
| * It is used to mark Tuta accounts as syncable as a fix for #6568 */ | ||
| class StubSyncService : Service() { | ||
| override fun onCreate() { | ||
| synchronized(syncAdapterLock) { |
There was a problem hiding this comment.
if it's never overwritten again wouldn't it be enough to either make it lazy or mark it as volatile?
| @@ -249,6 +252,10 @@ class AndroidMobileContactsFacade(private val activity: MainActivity) : MobileCo | |||
| activity.getPermission(Manifest.permission.WRITE_CONTACTS) | |||
| } | |||
|
|
|||
| private suspend fun checkSyncPermission() { | |||
| activity.getPermission(Manifest.permission.WRITE_SYNC_SETTINGS) | |||
There was a problem hiding this comment.
is user prompted for this or is it automatically given?
There was a problem hiding this comment.
From my testing, it is automatically given.
There was a problem hiding this comment.
I guess it does not hurt to check although for the same target API it shouldn't change.
|
Looks good, one mistery is solved! Maybe one day we can also do a "real" sync adapter |
rezbyte
force-pushed
the
6568-contacts-not-listed
branch
from
0f18ec1
to
e2e20fd
Compare
Certain contact apps require the account to be syncable. In order to do this, we implement a stubbed sync service and adapter which does nothing and ask Android not to call it. Preexisting installations of the app will need to turn contact synchronization off and on again to receive this fix. Closes #6568. Co-authored-by: paw <[email protected]>
charlag
force-pushed
the
6568-contacts-not-listed
branch
from
e2e20fd
to
47f031a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain contact apps require the account to be syncable. In order to do this, we implement a stubbed sync service and adapter which does nothing and ask Android not to call it. Preexisting installations of the app will need to turn contact synchronization off and on again to receive this fix.
Closes #6568.