Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dropdown keyboard fixes #32954

Closed
XhmikosR opened this issue Feb 1, 2021 · 4 comments · Fixed by #34052
Closed

dropdown keyboard fixes #32954

XhmikosR opened this issue Feb 1, 2021 · 4 comments · Fixed by #34052

Comments

@XhmikosR
Copy link
Member

XhmikosR commented Feb 1, 2021

BTW does it make sense to open the dropdown but not select the first/last element depending on the arrow key?

I feel like it's an extra key. But that's for later too. :)

Originally posted by @XhmikosR in #32750 (comment)

@XhmikosR
Copy link
Member Author

XhmikosR commented Feb 1, 2021

I guess for v5 that's OK to do, for v4 not sure if it's a considered a breaking change. But the current situation does not make a lot of sense to me.

@sijusamson
Copy link
Contributor

I would be working on this :-)

@XhmikosR
Copy link
Member Author

XhmikosR commented Feb 7, 2021

Thanks! See if you can deduplicate the code to get rid of the linting warning too :)

@sijusamson
Copy link
Contributor

@XhmikosR I was able to fix the issue, but I couldn't find any alternate solution to remove the linting warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment