Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow offcanvas to be initialized in open state #33382

Merged
merged 8 commits into from
Mar 23, 2021

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Mar 16, 2021

According to this offcanvas should be able to initialized on shown state if it has the show class on its markup .
I am not sure of this. Any Opinions?
(tests will be added after decision is made)

Preview
Closes #33372

@iainhallam
Copy link

May be worth noting the current documentation implies that this is possible on line 182:

If you’d like it to default open, add the additional class show.

@GeoSot GeoSot changed the title Allow offcanvas to be initialized open Allow offcanvas to be initialized in open state Mar 16, 2021
@GeoSot GeoSot marked this pull request as draft March 16, 2021 21:51
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ayy this looks good to me. I've updated the first example in the docs for this to put it to use. Now makes it much more dynamic inside the example.

@XhmikosR
Copy link
Member

This needs some more work on the JS side for sure and the example blocks page scrolling now until the example is closed :P

@GeoSot GeoSot force-pushed the gs-initialize-offcanvas-with-is_shown-false branch from 71dfb0d to 9f0e7ef Compare March 17, 2021 22:29
@GeoSot GeoSot force-pushed the gs-initialize-offcanvas-with-is_shown-false branch 4 times, most recently from 91ac502 to f6572d0 Compare March 18, 2021 00:22
@GeoSot GeoSot force-pushed the gs-initialize-offcanvas-with-is_shown-false branch from f6572d0 to a817e05 Compare March 18, 2021 00:24
@GeoSot GeoSot marked this pull request as ready for review March 18, 2021 00:27
@GeoSot GeoSot requested a review from a team as a code owner March 18, 2021 00:27
@mdo
Copy link
Member

mdo commented Mar 22, 2021

How we looking here? :)

@GeoSot
Copy link
Member Author

GeoSot commented Mar 22, 2021

seems ok. It was a minor change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v5 Offcanvas: Not visible on page load with show class
4 participants