Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new docs footer #33453

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Add new docs footer #33453

merged 2 commits into from
Mar 31, 2021

Conversation

mdo
Copy link
Member

@mdo mdo commented Mar 23, 2021

Screen Shot 2021-03-23 at 3 37 28 PM

Replaces the tiny footer with something more representative of the community projects, resources, and links.

Preview: https://deploy-preview-33453--twbs-bootstrap.netlify.app/

@mdo mdo requested a review from a team as a code owner March 23, 2021 22:38
@XhmikosR
Copy link
Member

XhmikosR commented Mar 24, 2021

I like it! One thought, though, perhaps using 5 is too much empty space? Maybe try with pt-4, mt-4, py-4 and see how it looks?

EDIT:

Oh, also, the footer links don't really make out here

image

Maybe a little bolder (font-weight: 600;) should do it:

image

EDIT2: Not sure about still using .small either.

@ffoodd
Copy link
Member

ffoodd commented Mar 24, 2021

Very nice!

@mdo
Copy link
Member Author

mdo commented Mar 31, 2021

Liking the space and contrast for now on links—they should be very subdued for this. Happy to iterate later though.

@mdo mdo merged commit 6e7f1a9 into main Mar 31, 2021
@mdo mdo deleted the v5-new-footer branch March 31, 2021 06:08
@XhmikosR
Copy link
Member

noopener is probably useless without target="_blank" so this should be addressed for sure.

Also, I do think it'd be better if the footer links were moved in data later and I definitely think the space is just too much.

Just my 2 cents :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants