Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileNotFoundError, Failed to list the news fragment files #538

Closed
jaraco opened this issue Jul 30, 2023 · 6 comments · Fixed by #557
Closed

FileNotFoundError, Failed to list the news fragment files #538

jaraco opened this issue Jul 30, 2023 · 6 comments · Fixed by #557

Comments

@jaraco
Copy link
Contributor

jaraco commented Jul 30, 2023

After adopting towncrier for the hundreds of projects that depend on jaraco/skeleton, I've been pleased to say that it has helped streamline the changelog generation.

I've tried as much as possible to minimize the amount of config required (relying on towncrier to provide best practices by default). Unfortunately, if I try to cut a release when there are no newsfragments, the "finalize" step fails:

 pytest-checkdocs main @ tox -e finalize
finalize: commands[0]> python -m jaraco.develop.finalize
Loading template...
Finding news fragments...
Failed to list the news fragment files.
FileNotFoundError: [Errno 2] No such file or directory: '/Users/jaraco/code/jaraco/pytest-checkdocs/newsfragments'

I can work around the issue by first running mkdir -p newsfragments, but I'd rather not have to add that step. I know I can create a permanent newsfragments directory in every project, but that requires adding a sentinel file to keep it present. And given that towncrier already works well to create that directory when it doesn't exist, I'd like it to fall back to the degenerate behavior when running build.

Can you update towncrier build to treat a missing fragments directory as the same as an empty directory, same as towcrier create?

jaraco added a commit to jaraco/jaraco.develop that referenced this issue Jul 30, 2023
@adiroiban
Copy link
Member

Thanks for the report.

if I try to cut a release when there are no newsfragments,

I am not sure I understand the use case here.
If there are no newsfragments, it means there are no changes since the last release...so why do a release?


Can you update towncrier build to treat a missing fragments directory as the same as an empty directory, same as towcrier create?

I would say that this is a feature and can help for example detect a misconfiguration / typo in the config.

If you want to build the release notes but the release notes fragments are not to be found, most probably this is an issue.


But as mentioned before, it might be that I don't understand the use case.

My suggesting is to try to send a PR starting with updating the docs to document this functionality. My hope is in this way, it should easier to understand the context in which towncrier is used.

Regards

@jaraco
Copy link
Contributor Author

jaraco commented Aug 3, 2023

I am not sure I understand the use case here.
If there are no newsfragments, it means there are no changes since the last release...so why do a release?

Sometimes, the changes are too minor to mention (fixing typos or package metadata) but I still want to get them out to catch unexpected regressions or to limit the number of uninteresting changes in future releases. Towncrier supports a null newsfragments set and uses no significant changes when that's the case. For example, see the v7.7.1 release of calendra, where the badge had some syntax errors and I wanted to get those repaired so they'd appear correctly in PyPI, even though it had no user-facing impact and wasn't worth documenting twice or v2.10.1 of pytest-checkdocs where the project skeleton was updated and an old deprecation suppression was removed.

This feature (the ability to release without making a fuss) was one of the must-have features for me to adopt towncrier. Because I maintain hundreds of packages, my maintenance process needs to be featherweight.

I would say that this is a feature and can help for example detect a misconfiguration / typo in the config.

If that's the case, then shouldn't also create fail if the directory doesn't exist? I seems to me that if the philosophy allows creation of entries without the directory and it allows building an empty directory with no entries, it should also allow building without the directory, especially because it's an unnecessary nuisance to require each project to manage retention of that directory in version control.

If you want to build the release notes but the release notes fragments are not to be found, most probably this is an issue.

In my case, it's not. Towncrier provides value by providing a unified process for finalizing the release (adding the heading, which itself communicates the version and the date it was tagged), even if there were no noteworthy changes. And the fact that the code already supports rendering an empty directory suggests that a misconfiguration doesn't necessarily justify the hard fail.

My suggesting is to try to send a PR starting with updating the docs to document this functionality.

Will do. Thanks.

@adiroiban
Copy link
Member

Hi,

In release 22.12.0 , this #428 was merged.

Would that work for you ?


You can now create fragments that are not associated with issues. Start the name of the fragment with + (e.g. +anything.feature). The content of these orphan news fragments will be included in the release notes, at the end of the category corresponding to the file extension.

To help quickly create a unique orphan news fragment, towncrier create +.feature will append a random string to the base name of the file, to avoid name collisions. (#428)

@jaraco
Copy link
Contributor Author

jaraco commented Oct 24, 2023

Would that work for you ?

I've used and appreciate that feature, but it doesn't address the reported issue. I'm still planning to create a PR. You can assign this issue to me if you like.

jaraco added a commit to jaraco/towncrier that referenced this issue Oct 24, 2023
jaraco added a commit to jaraco/towncrier that referenced this issue Oct 24, 2023
jaraco added a commit to jaraco/towncrier that referenced this issue Oct 24, 2023
jaraco added a commit to jaraco/towncrier that referenced this issue Oct 24, 2023
jaraco added a commit to jaraco/towncrier that referenced this issue Oct 24, 2023
@adiroiban
Copy link
Member

Thanks for the feedback. I wasn't sure what is the use case here.

For the towncrier "phiplosophy" it makes no sense to make a release without any changes.
An any change should have a news fragment file :)

You can make a change without having a ticket using the #428 feature.


If I understand correclty, you are asking for the following feature:

Run towncrier create even if there are no news fragment.
It should not fail.
It should create a new section with the current version and date and mention that no changes were done in the release.

Is that correct?


As you mention, if towncrier already works with an empty dir, and this helps with your maintance work, I think it makes to ignore the missing fragment dir and just consider it empty.

If you have a misconfiguration, you will see the empty release and then you can troubleshoot.

One of the goals of towncrier is to make the life easier for release managers :)


No need to assign this.

You can work when you have time.

jaraco added a commit to jaraco/towncrier that referenced this issue Oct 24, 2023
@jaraco
Copy link
Contributor Author

jaraco commented Oct 24, 2023

It should create a new section with the current version and date and mention that no changes were done in the release.

Correct, same as for an empty directory.

adiroiban pushed a commit that referenced this issue Oct 24, 2023
…ry (#557)

* Add some documentation explaining the current behavior around the fragments directory.

* Reflect expectation that a non-existent directory is honored and treated like an empty directory. Closes #538.

* Add news fragment.
github-actions bot pushed a commit to aio-libs/aiohttp that referenced this issue Nov 9, 2023
Bumps [towncrier](https:/twisted/towncrier) from 23.10.0 to
23.11.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https:/twisted/towncrier/releases">towncrier's
releases</a>.</em></p>
<blockquote>
<h2>Towncrier 23.11.0</h2>
<h1>towncrier 23.11.0 (2023-11-08)</h1>
<h2>Bugfixes</h2>
<ul>
<li><code>build</code> now treats a missing fragments directory the same
as an
empty one, consistent with other operations.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/538">#538</a>)</li>
<li>Fragments with filenames like
<!-- raw HTML omitted -->fix-1.2.3.feature<!-- raw HTML omitted --> are
now associated
with the ticket <!-- raw HTML omitted -->fix-1.2.3<!-- raw HTML omitted
-->. In
previous versions they were incorrectly associated to ticket
<!-- raw HTML omitted -->3<!-- raw HTML omitted -->.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/562">#562</a>)</li>
<li>Orphan newsfragments containing numeric values are no longer
accidentally associated to tickets. In previous versions the orphan
marker was ignored and the newsfragment was associated to a ticket
having the last numerical value from the filename.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/562">#562</a>)</li>
</ul>
<h2>Misc</h2>
<ul>
<li><a
href="https://redirect.github.com/twisted/towncrier/issues/558">#558</a>,
<a
href="https://redirect.github.com/twisted/towncrier/issues/559">#559</a></li>
</ul>
<h2>Towncrier 23.11.0rc1</h2>
<h1>towncrier 23.11.0rc1 (2023-11-07)</h1>
<h2>Bugfixes</h2>
<ul>
<li><code>build</code> now treats a missing fragments directory the same
as an
empty one, consistent with other operations.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/538">#538</a>)</li>
<li>Fragments with filenames like
<!-- raw HTML omitted -->fix-1.2.3.feature<!-- raw HTML omitted --> are
now associated
with the ticket <!-- raw HTML omitted -->fix-1.2.3<!-- raw HTML omitted
-->. In
previous versions they were incorrectly associated to ticket
<!-- raw HTML omitted -->3<!-- raw HTML omitted -->.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/562">#562</a>)</li>
<li>Orphan newsfragments containing numeric values are no longer
accidentally associated to tickets. In previous versions the orphan
marker was ignored and the newsfragment was associated to a ticket
having the last numerical value from the filename.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/562">#562</a>)</li>
</ul>
<h2>Misc</h2>
<ul>
<li><a
href="https://redirect.github.com/twisted/towncrier/issues/558">#558</a>,
<a
href="https://redirect.github.com/twisted/towncrier/issues/559">#559</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https:/twisted/towncrier/blob/trunk/NEWS.rst">towncrier's
changelog</a>.</em></p>
<blockquote>
<h1>towncrier 23.11.0 (2023-11-08)</h1>
<p>No significant changes since the previous release candidate.</p>
<h2>Bugfixes</h2>
<ul>
<li><code>build</code> now treats a missing fragments directory the same
as an empty one, consistent with other operations.
(<code>[#538](twisted/towncrier#538)
&lt;https:/twisted/towncrier/issues/538&gt;</code>_)</li>
<li>Fragments with filenames like <code>fix-1.2.3.feature</code> are now
associated with the ticket <code>fix-1.2.3</code>.
In previous versions they were incorrectly associated to ticket
<code>3</code>.
(<code>[#562](twisted/towncrier#562)
&lt;https:/twisted/towncrier/issues/562&gt;</code>_)</li>
<li>Orphan newsfragments containing numeric values are no longer
accidentally associated to tickets. In previous versions the orphan
marker was ignored and the newsfragment was associated to a ticket
having the last numerical value from the filename.
(<code>[#562](twisted/towncrier#562)
&lt;https:/twisted/towncrier/issues/562&gt;</code>_)</li>
</ul>
<h2>Misc</h2>
<ul>
<li><code>[#558](twisted/towncrier#558)
&lt;https:/twisted/towncrier/issues/558&gt;</code><em>,
<code>[#559](twisted/towncrier#559)
&lt;https:/twisted/towncrier/issues/559&gt;</code></em></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https:/twisted/towncrier/commit/503b499a1ddb13d6c526e5d5511767e53d809e68"><code>503b499</code></a>
Update final version.</li>
<li><a
href="https:/twisted/towncrier/commit/bdb1d080e40babc7da54d3f6def37862d0cdcb94"><code>bdb1d08</code></a>
[pre-commit.ci] auto fixes from pre-commit.com hooks</li>
<li><a
href="https:/twisted/towncrier/commit/47cf0f3b1d5f4be082fbddbad9b945274eb4d6bb"><code>47cf0f3</code></a>
Show release draft as a step output.</li>
<li><a
href="https:/twisted/towncrier/commit/8b9b4b24136c628c874400ad1e9dd3a4a0a2c9bc"><code>8b9b4b2</code></a>
venv/bin/towncrier build --yes</li>
<li><a
href="https:/twisted/towncrier/commit/3b27ce2e7ec2f219a8a655001bc21e5d4ba57412"><code>3b27ce2</code></a>
Fix orphan fragments with numbers (<a
href="https://redirect.github.com/twisted/towncrier/issues/564">#564</a>)</li>
<li><a
href="https:/twisted/towncrier/commit/a275be976216b7e11b896b63df7fd9fcbccc0023"><code>a275be9</code></a>
[pre-commit.ci] pre-commit autoupdate (<a
href="https://redirect.github.com/twisted/towncrier/issues/563">#563</a>)</li>
<li><a
href="https:/twisted/towncrier/commit/a794718b345cb332cd16ce9a807f4c02c68088d3"><code>a794718</code></a>
Update the documentation for the release process. (<a
href="https://redirect.github.com/twisted/towncrier/issues/558">#558</a>)</li>
<li><a
href="https:/twisted/towncrier/commit/fba26a53022d6b5199a171018e0532a9ee59b596"><code>fba26a5</code></a>
Update build-and-inspect-python-package to 1.5.2 (<a
href="https://redirect.github.com/twisted/towncrier/issues/559">#559</a>)</li>
<li><a
href="https:/twisted/towncrier/commit/e4b892fb21afce321a132780b7d4cf34814da7cb"><code>e4b892f</code></a>
Make consistent the expectation around non-existent fragments directory
(<a
href="https://redirect.github.com/twisted/towncrier/issues/557">#557</a>)</li>
<li><a
href="https:/twisted/towncrier/commit/f6809f031fce9fe3568166247f8ccf8f7a6c4aaf"><code>f6809f0</code></a>
Release 23.10.0 (<a
href="https://redirect.github.com/twisted/towncrier/issues/555">#555</a>)</li>
<li>See full diff in <a
href="https:/twisted/towncrier/compare/23.10.0...23.11.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=towncrier&package-manager=pip&previous-version=23.10.0&new-version=23.11.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
github-actions bot pushed a commit to aio-libs/aiohttp that referenced this issue Nov 9, 2023
Bumps [towncrier](https:/twisted/towncrier) from 23.10.0 to
23.11.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https:/twisted/towncrier/releases">towncrier's
releases</a>.</em></p>
<blockquote>
<h2>Towncrier 23.11.0</h2>
<h1>towncrier 23.11.0 (2023-11-08)</h1>
<h2>Bugfixes</h2>
<ul>
<li><code>build</code> now treats a missing fragments directory the same
as an
empty one, consistent with other operations.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/538">#538</a>)</li>
<li>Fragments with filenames like
<!-- raw HTML omitted -->fix-1.2.3.feature<!-- raw HTML omitted --> are
now associated
with the ticket <!-- raw HTML omitted -->fix-1.2.3<!-- raw HTML omitted
-->. In
previous versions they were incorrectly associated to ticket
<!-- raw HTML omitted -->3<!-- raw HTML omitted -->.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/562">#562</a>)</li>
<li>Orphan newsfragments containing numeric values are no longer
accidentally associated to tickets. In previous versions the orphan
marker was ignored and the newsfragment was associated to a ticket
having the last numerical value from the filename.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/562">#562</a>)</li>
</ul>
<h2>Misc</h2>
<ul>
<li><a
href="https://redirect.github.com/twisted/towncrier/issues/558">#558</a>,
<a
href="https://redirect.github.com/twisted/towncrier/issues/559">#559</a></li>
</ul>
<h2>Towncrier 23.11.0rc1</h2>
<h1>towncrier 23.11.0rc1 (2023-11-07)</h1>
<h2>Bugfixes</h2>
<ul>
<li><code>build</code> now treats a missing fragments directory the same
as an
empty one, consistent with other operations.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/538">#538</a>)</li>
<li>Fragments with filenames like
<!-- raw HTML omitted -->fix-1.2.3.feature<!-- raw HTML omitted --> are
now associated
with the ticket <!-- raw HTML omitted -->fix-1.2.3<!-- raw HTML omitted
-->. In
previous versions they were incorrectly associated to ticket
<!-- raw HTML omitted -->3<!-- raw HTML omitted -->.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/562">#562</a>)</li>
<li>Orphan newsfragments containing numeric values are no longer
accidentally associated to tickets. In previous versions the orphan
marker was ignored and the newsfragment was associated to a ticket
having the last numerical value from the filename.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/562">#562</a>)</li>
</ul>
<h2>Misc</h2>
<ul>
<li><a
href="https://redirect.github.com/twisted/towncrier/issues/558">#558</a>,
<a
href="https://redirect.github.com/twisted/towncrier/issues/559">#559</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https:/twisted/towncrier/blob/trunk/NEWS.rst">towncrier's
changelog</a>.</em></p>
<blockquote>
<h1>towncrier 23.11.0 (2023-11-08)</h1>
<p>No significant changes since the previous release candidate.</p>
<h2>Bugfixes</h2>
<ul>
<li><code>build</code> now treats a missing fragments directory the same
as an empty one, consistent with other operations.
(<code>[#538](twisted/towncrier#538)
&lt;https:/twisted/towncrier/issues/538&gt;</code>_)</li>
<li>Fragments with filenames like <code>fix-1.2.3.feature</code> are now
associated with the ticket <code>fix-1.2.3</code>.
In previous versions they were incorrectly associated to ticket
<code>3</code>.
(<code>[#562](twisted/towncrier#562)
&lt;https:/twisted/towncrier/issues/562&gt;</code>_)</li>
<li>Orphan newsfragments containing numeric values are no longer
accidentally associated to tickets. In previous versions the orphan
marker was ignored and the newsfragment was associated to a ticket
having the last numerical value from the filename.
(<code>[#562](twisted/towncrier#562)
&lt;https:/twisted/towncrier/issues/562&gt;</code>_)</li>
</ul>
<h2>Misc</h2>
<ul>
<li><code>[#558](twisted/towncrier#558)
&lt;https:/twisted/towncrier/issues/558&gt;</code><em>,
<code>[#559](twisted/towncrier#559)
&lt;https:/twisted/towncrier/issues/559&gt;</code></em></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https:/twisted/towncrier/commit/503b499a1ddb13d6c526e5d5511767e53d809e68"><code>503b499</code></a>
Update final version.</li>
<li><a
href="https:/twisted/towncrier/commit/bdb1d080e40babc7da54d3f6def37862d0cdcb94"><code>bdb1d08</code></a>
[pre-commit.ci] auto fixes from pre-commit.com hooks</li>
<li><a
href="https:/twisted/towncrier/commit/47cf0f3b1d5f4be082fbddbad9b945274eb4d6bb"><code>47cf0f3</code></a>
Show release draft as a step output.</li>
<li><a
href="https:/twisted/towncrier/commit/8b9b4b24136c628c874400ad1e9dd3a4a0a2c9bc"><code>8b9b4b2</code></a>
venv/bin/towncrier build --yes</li>
<li><a
href="https:/twisted/towncrier/commit/3b27ce2e7ec2f219a8a655001bc21e5d4ba57412"><code>3b27ce2</code></a>
Fix orphan fragments with numbers (<a
href="https://redirect.github.com/twisted/towncrier/issues/564">#564</a>)</li>
<li><a
href="https:/twisted/towncrier/commit/a275be976216b7e11b896b63df7fd9fcbccc0023"><code>a275be9</code></a>
[pre-commit.ci] pre-commit autoupdate (<a
href="https://redirect.github.com/twisted/towncrier/issues/563">#563</a>)</li>
<li><a
href="https:/twisted/towncrier/commit/a794718b345cb332cd16ce9a807f4c02c68088d3"><code>a794718</code></a>
Update the documentation for the release process. (<a
href="https://redirect.github.com/twisted/towncrier/issues/558">#558</a>)</li>
<li><a
href="https:/twisted/towncrier/commit/fba26a53022d6b5199a171018e0532a9ee59b596"><code>fba26a5</code></a>
Update build-and-inspect-python-package to 1.5.2 (<a
href="https://redirect.github.com/twisted/towncrier/issues/559">#559</a>)</li>
<li><a
href="https:/twisted/towncrier/commit/e4b892fb21afce321a132780b7d4cf34814da7cb"><code>e4b892f</code></a>
Make consistent the expectation around non-existent fragments directory
(<a
href="https://redirect.github.com/twisted/towncrier/issues/557">#557</a>)</li>
<li><a
href="https:/twisted/towncrier/commit/f6809f031fce9fe3568166247f8ccf8f7a6c4aaf"><code>f6809f0</code></a>
Release 23.10.0 (<a
href="https://redirect.github.com/twisted/towncrier/issues/555">#555</a>)</li>
<li>See full diff in <a
href="https:/twisted/towncrier/compare/23.10.0...23.11.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=towncrier&package-manager=pip&previous-version=23.10.0&new-version=23.11.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
xiangxli pushed a commit to xiangxli/aiohttp that referenced this issue Dec 4, 2023
Bumps [towncrier](https:/twisted/towncrier) from 23.10.0 to
23.11.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https:/twisted/towncrier/releases">towncrier's
releases</a>.</em></p>
<blockquote>
<h2>Towncrier 23.11.0</h2>
<h1>towncrier 23.11.0 (2023-11-08)</h1>
<h2>Bugfixes</h2>
<ul>
<li><code>build</code> now treats a missing fragments directory the same
as an
empty one, consistent with other operations.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/538">#538</a>)</li>
<li>Fragments with filenames like
<!-- raw HTML omitted -->fix-1.2.3.feature<!-- raw HTML omitted --> are
now associated
with the ticket <!-- raw HTML omitted -->fix-1.2.3<!-- raw HTML omitted
-->. In
previous versions they were incorrectly associated to ticket
<!-- raw HTML omitted -->3<!-- raw HTML omitted -->.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/562">#562</a>)</li>
<li>Orphan newsfragments containing numeric values are no longer
accidentally associated to tickets. In previous versions the orphan
marker was ignored and the newsfragment was associated to a ticket
having the last numerical value from the filename.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/562">#562</a>)</li>
</ul>
<h2>Misc</h2>
<ul>
<li><a
href="https://redirect.github.com/twisted/towncrier/issues/558">#558</a>,
<a
href="https://redirect.github.com/twisted/towncrier/issues/559">#559</a></li>
</ul>
<h2>Towncrier 23.11.0rc1</h2>
<h1>towncrier 23.11.0rc1 (2023-11-07)</h1>
<h2>Bugfixes</h2>
<ul>
<li><code>build</code> now treats a missing fragments directory the same
as an
empty one, consistent with other operations.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/538">#538</a>)</li>
<li>Fragments with filenames like
<!-- raw HTML omitted -->fix-1.2.3.feature<!-- raw HTML omitted --> are
now associated
with the ticket <!-- raw HTML omitted -->fix-1.2.3<!-- raw HTML omitted
-->. In
previous versions they were incorrectly associated to ticket
<!-- raw HTML omitted -->3<!-- raw HTML omitted -->.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/562">#562</a>)</li>
<li>Orphan newsfragments containing numeric values are no longer
accidentally associated to tickets. In previous versions the orphan
marker was ignored and the newsfragment was associated to a ticket
having the last numerical value from the filename.
(<a
href="https://redirect.github.com/twisted/towncrier/issues/562">#562</a>)</li>
</ul>
<h2>Misc</h2>
<ul>
<li><a
href="https://redirect.github.com/twisted/towncrier/issues/558">#558</a>,
<a
href="https://redirect.github.com/twisted/towncrier/issues/559">#559</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https:/twisted/towncrier/blob/trunk/NEWS.rst">towncrier's
changelog</a>.</em></p>
<blockquote>
<h1>towncrier 23.11.0 (2023-11-08)</h1>
<p>No significant changes since the previous release candidate.</p>
<h2>Bugfixes</h2>
<ul>
<li><code>build</code> now treats a missing fragments directory the same
as an empty one, consistent with other operations.
(<code>[aio-libs#538](twisted/towncrier#538)
&lt;https:/twisted/towncrier/issues/538&gt;</code>_)</li>
<li>Fragments with filenames like <code>fix-1.2.3.feature</code> are now
associated with the ticket <code>fix-1.2.3</code>.
In previous versions they were incorrectly associated to ticket
<code>3</code>.
(<code>[aio-libs#562](twisted/towncrier#562)
&lt;https:/twisted/towncrier/issues/562&gt;</code>_)</li>
<li>Orphan newsfragments containing numeric values are no longer
accidentally associated to tickets. In previous versions the orphan
marker was ignored and the newsfragment was associated to a ticket
having the last numerical value from the filename.
(<code>[aio-libs#562](twisted/towncrier#562)
&lt;https:/twisted/towncrier/issues/562&gt;</code>_)</li>
</ul>
<h2>Misc</h2>
<ul>
<li><code>[aio-libs#558](twisted/towncrier#558)
&lt;https:/twisted/towncrier/issues/558&gt;</code><em>,
<code>[aio-libs#559](twisted/towncrier#559)
&lt;https:/twisted/towncrier/issues/559&gt;</code></em></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https:/twisted/towncrier/commit/503b499a1ddb13d6c526e5d5511767e53d809e68"><code>503b499</code></a>
Update final version.</li>
<li><a
href="https:/twisted/towncrier/commit/bdb1d080e40babc7da54d3f6def37862d0cdcb94"><code>bdb1d08</code></a>
[pre-commit.ci] auto fixes from pre-commit.com hooks</li>
<li><a
href="https:/twisted/towncrier/commit/47cf0f3b1d5f4be082fbddbad9b945274eb4d6bb"><code>47cf0f3</code></a>
Show release draft as a step output.</li>
<li><a
href="https:/twisted/towncrier/commit/8b9b4b24136c628c874400ad1e9dd3a4a0a2c9bc"><code>8b9b4b2</code></a>
venv/bin/towncrier build --yes</li>
<li><a
href="https:/twisted/towncrier/commit/3b27ce2e7ec2f219a8a655001bc21e5d4ba57412"><code>3b27ce2</code></a>
Fix orphan fragments with numbers (<a
href="https://redirect.github.com/twisted/towncrier/issues/564">#564</a>)</li>
<li><a
href="https:/twisted/towncrier/commit/a275be976216b7e11b896b63df7fd9fcbccc0023"><code>a275be9</code></a>
[pre-commit.ci] pre-commit autoupdate (<a
href="https://redirect.github.com/twisted/towncrier/issues/563">#563</a>)</li>
<li><a
href="https:/twisted/towncrier/commit/a794718b345cb332cd16ce9a807f4c02c68088d3"><code>a794718</code></a>
Update the documentation for the release process. (<a
href="https://redirect.github.com/twisted/towncrier/issues/558">#558</a>)</li>
<li><a
href="https:/twisted/towncrier/commit/fba26a53022d6b5199a171018e0532a9ee59b596"><code>fba26a5</code></a>
Update build-and-inspect-python-package to 1.5.2 (<a
href="https://redirect.github.com/twisted/towncrier/issues/559">#559</a>)</li>
<li><a
href="https:/twisted/towncrier/commit/e4b892fb21afce321a132780b7d4cf34814da7cb"><code>e4b892f</code></a>
Make consistent the expectation around non-existent fragments directory
(<a
href="https://redirect.github.com/twisted/towncrier/issues/557">#557</a>)</li>
<li><a
href="https:/twisted/towncrier/commit/f6809f031fce9fe3568166247f8ccf8f7a6c4aaf"><code>f6809f0</code></a>
Release 23.10.0 (<a
href="https://redirect.github.com/twisted/towncrier/issues/555">#555</a>)</li>
<li>See full diff in <a
href="https:/twisted/towncrier/compare/23.10.0...23.11.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=towncrier&package-manager=pip&previous-version=23.10.0&new-version=23.11.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants